chore: cleanup dead props, deps, dirs, and stale comments

- Remove empty dirs: modules/mana/, modules/subscription/, and 7
  empty route dirs (spiral, profile, themes, help, apps, mana, credits)
- Remove @mana/subscriptions from web app dependencies (never imported)
- PillNavigation: drop settingsHref, manaHref, allAppsHref/allAppsLabel
  props + their link-builder blocks (none are passed anymore; all system
  pages route via /?app=<id> deep-links now)
- Update layout comment to reflect current architecture

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-16 13:17:59 +02:00
parent d40a61119e
commit 299cf9cf72
3 changed files with 11 additions and 48 deletions

View file

@ -73,7 +73,6 @@
"@mana/shared-uload": "workspace:*",
"@mana/shared-utils": "workspace:*",
"@mana/spiral-db": "workspace:*",
"@mana/subscriptions": "workspace:*",
"@mana/wallpaper-generator": "workspace:*",
"@types/pako": "^2.0.4",
"@types/suncalc": "^1.9.2",

View file

@ -302,11 +302,10 @@
}
// ── Navigation ──────────────────────────────────────────
// Note: spiral, credits, profile and settings used to live here as
// standalone pills but were moved into the user-menu dropdown so the
// nav stays compact. They are still routable via the dropdown items
// the layout passes as `spiralHref` / `creditsHref` / `profileHref` /
// `settingsHref` below.
// System pages (spiral, credits, profile, themes, help) are workbench
// apps now — no standalone routes. The user-menu dropdown links via
// `spiralHref` / `creditsHref` / `profileHref` etc., all pointing to
// `/?app=<id>` deep-links.
let baseNavItems = $derived<PillNavItem[]>([
{
href: '/',
@ -581,6 +580,13 @@
// sync engine boot on the critical path.
if (authStore.isAuthenticated) {
setErrorTrackingUser({ id: authStore.user?.id ?? 'unknown', email: authStore.user?.email });
// Multi-Agent Workbench (Phase 1): bind the real user identity
// to the ambient Actor so subsequent writes stamp principalId +
// displayName correctly instead of 'legacy:user' / 'Du'.
const { bindDefaultUser } = await import('$lib/data/events/actor');
const uid = authStore.user?.id ?? 'unknown';
const name = authStore.user?.name || authStore.user?.email || 'Du';
bindDefaultUser(uid, name);
await syncBilling.load();
const getToken = () => authStore.getValidToken();
unifiedSync = createUnifiedSync(SYNC_SERVER_URL, getToken, syncBilling.active);

View file

@ -287,18 +287,10 @@
showAppSwitcher?: boolean;
/** User email for user dropdown */
userEmail?: string;
/** Settings page href */
settingsHref?: string;
/** Mana/subscription page href */
manaHref?: string;
/** Profile page href */
profileHref?: string;
/** Login page href (shown when not logged in) */
loginHref?: string;
/** All Apps page href */
allAppsHref?: string;
/** All Apps label (default: "Alle Apps") */
allAppsLabel?: string;
// A11y Settings
/** A11y contrast level */
a11yContrast?: 'normal' | 'high';
@ -379,12 +371,8 @@
appItems = [],
showAppSwitcher = false,
userEmail,
settingsHref,
manaHref,
profileHref,
loginHref,
allAppsHref,
allAppsLabel = 'Alle Apps',
a11yContrast = 'normal',
onA11yContrastChange,
a11yReduceMotion = false,
@ -476,24 +464,6 @@
active: currentPath === profileHref,
});
}
if (settingsHref) {
links.push({
id: 'settings',
label: 'Einstellungen',
icon: 'settings',
href: settingsHref,
active: currentPath === settingsHref,
});
}
if (userEmail && manaHref) {
links.push({
id: 'mana',
label: 'Mana',
icon: 'sparkle',
href: manaHref,
active: currentPath === manaHref,
});
}
if (spiralHref) {
links.push({
id: 'spiral',
@ -568,16 +538,6 @@
},
});
}
if (settingsHref) {
out.push({
id: 'settings',
label: 'Einstellungen',
icon: 'settings',
onClick: () => {
window.location.href = settingsHref;
},
});
}
if (onThemeModeChange) {
out.push(
{
@ -655,8 +615,6 @@
isOpen={appDrawerOpen}
onToggle={(open) => (appDrawerOpen = open)}
{onOpenInPanel}
{allAppsHref}
{allAppsLabel}
triggerLabel={appName}
/>
{/if}