From 299cf9cf7204b075c01e71205fbae5d9a8074757 Mon Sep 17 00:00:00 2001 From: Till JS Date: Thu, 16 Apr 2026 13:17:59 +0200 Subject: [PATCH] chore: cleanup dead props, deps, dirs, and stale comments - Remove empty dirs: modules/mana/, modules/subscription/, and 7 empty route dirs (spiral, profile, themes, help, apps, mana, credits) - Remove @mana/subscriptions from web app dependencies (never imported) - PillNavigation: drop settingsHref, manaHref, allAppsHref/allAppsLabel props + their link-builder blocks (none are passed anymore; all system pages route via /?app= deep-links now) - Update layout comment to reflect current architecture Co-Authored-By: Claude Opus 4.6 (1M context) --- apps/mana/apps/web/package.json | 1 - .../apps/web/src/routes/(app)/+layout.svelte | 16 ++++--- .../src/navigation/PillNavigation.svelte | 42 ------------------- 3 files changed, 11 insertions(+), 48 deletions(-) diff --git a/apps/mana/apps/web/package.json b/apps/mana/apps/web/package.json index 0c369487f..2c7dc2644 100644 --- a/apps/mana/apps/web/package.json +++ b/apps/mana/apps/web/package.json @@ -73,7 +73,6 @@ "@mana/shared-uload": "workspace:*", "@mana/shared-utils": "workspace:*", "@mana/spiral-db": "workspace:*", - "@mana/subscriptions": "workspace:*", "@mana/wallpaper-generator": "workspace:*", "@types/pako": "^2.0.4", "@types/suncalc": "^1.9.2", diff --git a/apps/mana/apps/web/src/routes/(app)/+layout.svelte b/apps/mana/apps/web/src/routes/(app)/+layout.svelte index 5c2caf658..af3942ebf 100644 --- a/apps/mana/apps/web/src/routes/(app)/+layout.svelte +++ b/apps/mana/apps/web/src/routes/(app)/+layout.svelte @@ -302,11 +302,10 @@ } // ── Navigation ────────────────────────────────────────── - // Note: spiral, credits, profile and settings used to live here as - // standalone pills but were moved into the user-menu dropdown so the - // nav stays compact. They are still routable via the dropdown items - // the layout passes as `spiralHref` / `creditsHref` / `profileHref` / - // `settingsHref` below. + // System pages (spiral, credits, profile, themes, help) are workbench + // apps now — no standalone routes. The user-menu dropdown links via + // `spiralHref` / `creditsHref` / `profileHref` etc., all pointing to + // `/?app=` deep-links. let baseNavItems = $derived([ { href: '/', @@ -581,6 +580,13 @@ // sync engine boot on the critical path. if (authStore.isAuthenticated) { setErrorTrackingUser({ id: authStore.user?.id ?? 'unknown', email: authStore.user?.email }); + // Multi-Agent Workbench (Phase 1): bind the real user identity + // to the ambient Actor so subsequent writes stamp principalId + + // displayName correctly instead of 'legacy:user' / 'Du'. + const { bindDefaultUser } = await import('$lib/data/events/actor'); + const uid = authStore.user?.id ?? 'unknown'; + const name = authStore.user?.name || authStore.user?.email || 'Du'; + bindDefaultUser(uid, name); await syncBilling.load(); const getToken = () => authStore.getValidToken(); unifiedSync = createUnifiedSync(SYNC_SERVER_URL, getToken, syncBilling.active); diff --git a/packages/shared-ui/src/navigation/PillNavigation.svelte b/packages/shared-ui/src/navigation/PillNavigation.svelte index a502955ae..15eff0b72 100644 --- a/packages/shared-ui/src/navigation/PillNavigation.svelte +++ b/packages/shared-ui/src/navigation/PillNavigation.svelte @@ -287,18 +287,10 @@ showAppSwitcher?: boolean; /** User email for user dropdown */ userEmail?: string; - /** Settings page href */ - settingsHref?: string; - /** Mana/subscription page href */ - manaHref?: string; /** Profile page href */ profileHref?: string; /** Login page href (shown when not logged in) */ loginHref?: string; - /** All Apps page href */ - allAppsHref?: string; - /** All Apps label (default: "Alle Apps") */ - allAppsLabel?: string; // A11y Settings /** A11y contrast level */ a11yContrast?: 'normal' | 'high'; @@ -379,12 +371,8 @@ appItems = [], showAppSwitcher = false, userEmail, - settingsHref, - manaHref, profileHref, loginHref, - allAppsHref, - allAppsLabel = 'Alle Apps', a11yContrast = 'normal', onA11yContrastChange, a11yReduceMotion = false, @@ -476,24 +464,6 @@ active: currentPath === profileHref, }); } - if (settingsHref) { - links.push({ - id: 'settings', - label: 'Einstellungen', - icon: 'settings', - href: settingsHref, - active: currentPath === settingsHref, - }); - } - if (userEmail && manaHref) { - links.push({ - id: 'mana', - label: 'Mana', - icon: 'sparkle', - href: manaHref, - active: currentPath === manaHref, - }); - } if (spiralHref) { links.push({ id: 'spiral', @@ -568,16 +538,6 @@ }, }); } - if (settingsHref) { - out.push({ - id: 'settings', - label: 'Einstellungen', - icon: 'settings', - onClick: () => { - window.location.href = settingsHref; - }, - }); - } if (onThemeModeChange) { out.push( { @@ -655,8 +615,6 @@ isOpen={appDrawerOpen} onToggle={(open) => (appDrawerOpen = open)} {onOpenInPanel} - {allAppsHref} - {allAppsLabel} triggerLabel={appName} /> {/if}