mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-14 21:21:10 +02:00
42e5e97390
- Fix 121 accessibility warnings across 9 web apps (manacore, clock, chat, manadeck, calendar, zitare, contacts, picture, todo) - Add proper ARIA attributes (role, tabindex, aria-label) to interactive elements - Add onkeydown handlers alongside onclick for keyboard accessibility - Add svelte-ignore comments for intentional patterns (modals, dropdowns) - Update svelte-check threshold from error to warning in pre-commit hook - Fix script compatibility for bash 3.x (remove associative arrays) - Add comprehensive documentation for svelte-check patterns and fixes All web apps now pass svelte-check with 0 errors and 0 warnings. Pre-commit hooks will block any future commits with warnings.
84 lines
2.6 KiB
Bash
Executable file
84 lines
2.6 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# Run svelte-check on web apps that have staged .svelte files
|
|
# This catches a11y warnings, Svelte 5 issues, and import errors before CI
|
|
|
|
set -e
|
|
|
|
# Get list of staged svelte files
|
|
STAGED_SVELTE=$(git diff --cached --name-only --diff-filter=ACM | grep '\.svelte$' || true)
|
|
|
|
if [ -z "$STAGED_SVELTE" ]; then
|
|
echo "No staged .svelte files, skipping svelte-check"
|
|
exit 0
|
|
fi
|
|
|
|
# Find unique web app directories that have changes
|
|
WEB_APPS=""
|
|
|
|
for file in $STAGED_SVELTE; do
|
|
# Extract the web app path (e.g., apps/todo/apps/web)
|
|
app_path=""
|
|
if [[ $file =~ ^(apps/[^/]+/apps/web)/ ]]; then
|
|
app_path="${BASH_REMATCH[1]}"
|
|
elif [[ $file =~ ^(games/[^/]+/apps/web)/ ]]; then
|
|
app_path="${BASH_REMATCH[1]}"
|
|
elif [[ $file =~ ^(packages/[^/]+)/ ]]; then
|
|
# For shared packages, check all web apps that might use them
|
|
echo "⚠️ Changes in shared package: $file"
|
|
echo " Consider running: pnpm run build:check to verify all web apps"
|
|
fi
|
|
|
|
# Add to list if not already present
|
|
if [ -n "$app_path" ]; then
|
|
if [[ ! " $WEB_APPS " =~ " $app_path " ]]; then
|
|
WEB_APPS="$WEB_APPS $app_path"
|
|
fi
|
|
fi
|
|
done
|
|
|
|
# Trim leading space
|
|
WEB_APPS=$(echo "$WEB_APPS" | xargs)
|
|
|
|
if [ -z "$WEB_APPS" ]; then
|
|
echo "No web app changes detected"
|
|
exit 0
|
|
fi
|
|
|
|
echo "🔍 Running svelte-check on affected web apps..."
|
|
FAILED=0
|
|
|
|
for app in $WEB_APPS; do
|
|
if [ -f "$app/package.json" ]; then
|
|
echo ""
|
|
echo "━━━ Checking $app ━━━"
|
|
|
|
# Get the package name for pnpm filter
|
|
PKG_NAME=$(node -p "require('./$app/package.json').name" 2>/dev/null || echo "")
|
|
|
|
if [ -n "$PKG_NAME" ]; then
|
|
# Run svelte-check - fails on both errors AND warnings
|
|
# This ensures no a11y issues or Svelte problems slip through
|
|
if ! pnpm --filter "$PKG_NAME" exec svelte-check --tsconfig ./tsconfig.json --threshold warning 2>&1; then
|
|
echo "❌ svelte-check failed for $app"
|
|
FAILED=1
|
|
else
|
|
echo "✅ svelte-check passed for $app"
|
|
fi
|
|
fi
|
|
fi
|
|
done
|
|
|
|
if [ $FAILED -eq 1 ]; then
|
|
echo ""
|
|
echo "❌ svelte-check failed! Fix the issues above before committing."
|
|
echo ""
|
|
echo "Common fixes:"
|
|
echo " - Add role and tabindex to interactive divs"
|
|
echo " - Add onkeydown handler alongside onclick"
|
|
echo " - Use \$state() for reactive variables in Svelte 5"
|
|
echo " - Check that all imports resolve correctly"
|
|
exit 1
|
|
fi
|
|
|
|
echo ""
|
|
echo "✅ All svelte-checks passed!"
|