mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-15 03:41:10 +02:00
49935c9628
Scaffold the unified visibility/privacy layer introduced by docs/plans/
visibility-system.md. No module adopts it yet — this is the foundation
PR (M1). Module rollout lands in follow-ups starting with Library (M2).
What ships:
- @mana/shared-privacy package
- VisibilityLevel enum ('private' | 'space' | 'unlisted' | 'public')
- VisibilityLevelSchema + UnlistedTokenSchema (zod)
- defaultVisibilityFor(spaceType): personal → private, else → space
- predicates: canEmbedOnWebsite, isReachableByLink,
isVisibleToSpaceMember, canAiAccessCrossUser (always false in P1)
- generateUnlistedToken() — 32-char base64url, CSPRNG, ~192 bits
- VISIBILITY_METADATA: German labels + descriptions + phosphor icon
names so non-UI surfaces (audit logs, CLI) label levels consistently
- <VisibilityPicker> svelte component: compact lock/globe trigger with
4-option menu, full descriptions, optional compact + disabledLevels
- VisibilityChangedPayload type for the domain-event catalog (consumer
registers it when the first module adopts the system)
- .claude/guidelines/visibility.md — step-by-step for module authors
(schema migrations + store wiring + picker placement + embed resolver +
legacy isPublic migration), with a pre-PR checklist
- Plan-doc "Offene Fragen" section rewritten as "Designentscheidungen"
with the seven resolutions the user approved
- CLAUDE.md: shared-privacy listed in the packages table; visibility.md
listed in the guidelines table
- 15 unit tests covering predicates (one-and-only-one 'public' for
embed; phase-1 AI always-deny), defaults (personal vs multi-member,
null fallback), token uniqueness + schema round-trip
Key constraints honored:
- `visibility` stays plaintext (NOT added to the encryption registry)
so RLS predicates and publish resolvers can read it without the user's
master key
- Publish flow remains "decrypt client-side, inline plaintext into
snapshot" — the pattern picture.board already uses in embeds.ts
- Deny-by-default everywhere (personal default = private; unknown space
type defaults to private; cross-user AI always false)
Not in this PR (per plan):
- No schema migrations in any module (M2–M6)
- No RLS predicate updates (arrives with M2)
- No /settings/privacy overview (M7)
- No unlisted share routes (M8)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
45 lines
1.3 KiB
TypeScript
45 lines
1.3 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import {
|
|
canEmbedOnWebsite,
|
|
isReachableByLink,
|
|
isVisibleToSpaceMember,
|
|
canAiAccessCrossUser,
|
|
} from './predicates';
|
|
import { VISIBILITY_LEVELS } from './types';
|
|
|
|
describe('canEmbedOnWebsite', () => {
|
|
it('allows only public', () => {
|
|
expect(canEmbedOnWebsite('public')).toBe(true);
|
|
expect(canEmbedOnWebsite('unlisted')).toBe(false);
|
|
expect(canEmbedOnWebsite('space')).toBe(false);
|
|
expect(canEmbedOnWebsite('private')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('isReachableByLink', () => {
|
|
it('allows public and unlisted', () => {
|
|
expect(isReachableByLink('public')).toBe(true);
|
|
expect(isReachableByLink('unlisted')).toBe(true);
|
|
});
|
|
it('rejects space and private', () => {
|
|
expect(isReachableByLink('space')).toBe(false);
|
|
expect(isReachableByLink('private')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('isVisibleToSpaceMember', () => {
|
|
it('allows everything except private', () => {
|
|
expect(isVisibleToSpaceMember('space')).toBe(true);
|
|
expect(isVisibleToSpaceMember('unlisted')).toBe(true);
|
|
expect(isVisibleToSpaceMember('public')).toBe(true);
|
|
expect(isVisibleToSpaceMember('private')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('canAiAccessCrossUser', () => {
|
|
it('denies for every level in Phase 1', () => {
|
|
for (const lvl of VISIBILITY_LEVELS) {
|
|
expect(canAiAccessCrossUser(lvl)).toBe(false);
|
|
}
|
|
});
|
|
});
|