mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-23 17:06:41 +02:00
Pre-launch theme system audit found multiple parallel layers in themes.css
(--theme-X full hsl strings, --X partial shadcn aliases, --color-X populated
by runtime store with raw channels) plus dead-code companion files. The
inconsistency caused light-mode regressions when scoped-CSS consumers
wrote `var(--color-X)` standalone — the variable holds raw HSL channels
which is invalid as a color value, browser fell back to inherited (white).
Rewrite to one consistent layer:
- Source of truth: --color-X defined as raw HSL channels (e.g.
`0 0% 17%`) in :root, .dark, and all variant [data-theme="..."]
blocks. Matches the format the runtime store
(@mana/shared-theme/src/utils.ts) writes, eliminating the
static-fallback-vs-runtime mismatch and the corresponding flash
of unstyled content on hydration.
- @theme inline uses self-reference + Tailwind v4 <alpha-value>
placeholder so utility classes generate correctly AND opacity
modifiers work: `text-foreground/50` → `hsl(var(--color-foreground) / 0.5)`.
- @layer components (.btn-primary, .card, .badge, etc.) wraps
var(--color-X) refs with hsl() — they were broken in light mode
too for the same reason.
Convention going forward (also documented in the file header):
1. Markup: use Tailwind utility classes (text-foreground, bg-card, …)
2. Scoped CSS: hsl(var(--color-X)) — always wrap with hsl()
3. NEVER raw var(--color-X) in CSS — that's the bug pattern
Net file: 692 → 580 LOC. Single source layer, no indirection.
Also delete dead companion files (zero imports anywhere):
- tailwind-v4.css (had broken self-reference, never imported)
- theme-variables.css (legacy hex-based palette)
- components.css (legacy component utilities)
- index.js / preset.js / colors.js (Tailwind v3 preset format,
irrelevant under Tailwind v4)
package.json exports map shrinks accordingly to just `./themes.css`.
Consumers using `hsl(var(--color-X))` (~379 files across mana-web,
manavoxel-web, arcade-web) keep working unchanged — the public API
name `--color-X` is preserved. Only the broken pattern `var(--color-X)`
(~61 files) needs a follow-up sweep, handled in a separate commit.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
121 lines
3.8 KiB
TypeScript
121 lines
3.8 KiB
TypeScript
/**
|
|
* Music module — Audio upload, presigned URLs, cover art
|
|
* Renamed from Mukke.
|
|
*/
|
|
|
|
import { Hono } from 'hono';
|
|
import type { AuthVariables } from '@mana/shared-hono';
|
|
|
|
const routes = new Hono<{ Variables: AuthVariables }>();
|
|
|
|
// ─── Song Upload (presigned URL) ────────────────────────────
|
|
|
|
routes.post('/songs/upload', async (c) => {
|
|
const userId = c.get('userId');
|
|
const { filename } = await c.req.json();
|
|
if (!filename) return c.json({ error: 'filename required' }, 400);
|
|
|
|
const songId = crypto.randomUUID();
|
|
const key = `users/${userId}/songs/${songId}/${filename}`;
|
|
|
|
try {
|
|
const { createMusicStorage } = await import('@mana/shared-storage');
|
|
const storage = createMusicStorage();
|
|
const uploadUrl = await storage.getUploadUrl(key, { expiresIn: 3600 });
|
|
|
|
return c.json({
|
|
song: { id: songId, title: filename.replace(/\.[^/.]+$/, ''), storagePath: key },
|
|
uploadUrl,
|
|
});
|
|
} catch {
|
|
return c.json({ error: 'Failed to generate upload URL' }, 500);
|
|
}
|
|
});
|
|
|
|
// ─── Download URL ───────────────────────────────────────────
|
|
|
|
routes.get('/songs/:id/download-url', async (c) => {
|
|
const { storagePath } = c.req.query();
|
|
if (!storagePath) return c.json({ error: 'storagePath required' }, 400);
|
|
|
|
try {
|
|
const { createMusicStorage } = await import('@mana/shared-storage');
|
|
const storage = createMusicStorage();
|
|
const url = await storage.getDownloadUrl(storagePath, { expiresIn: 3600 });
|
|
return c.json({ url });
|
|
} catch {
|
|
return c.json({ error: 'Failed to generate download URL' }, 500);
|
|
}
|
|
});
|
|
|
|
// ─── Cover Art Upload (via mana-media) ─────────────────────
|
|
|
|
routes.post('/cover/upload', async (c) => {
|
|
const userId = c.get('userId');
|
|
const formData = await c.req.formData();
|
|
const file = formData.get('file') as File | null;
|
|
|
|
if (!file) return c.json({ error: 'No file' }, 400);
|
|
if (file.size > 10 * 1024 * 1024) return c.json({ error: 'Max 10MB' }, 400);
|
|
if (!file.type.startsWith('image/')) return c.json({ error: 'Must be an image' }, 400);
|
|
|
|
try {
|
|
const { uploadImageToMedia } = await import('../../lib/media');
|
|
const buffer = await file.arrayBuffer();
|
|
const result = await uploadImageToMedia(buffer, file.name, { app: 'music', userId });
|
|
|
|
return c.json(
|
|
{
|
|
coverArtPath: result.id,
|
|
coverUrl: result.urls.thumbnail || result.urls.original,
|
|
mediaId: result.id,
|
|
},
|
|
201
|
|
);
|
|
} catch {
|
|
return c.json({ error: 'Upload failed' }, 500);
|
|
}
|
|
});
|
|
|
|
// ─── Cover Art URL ──────────────────────────────────────────
|
|
|
|
routes.get('/songs/:id/cover-url', async (c) => {
|
|
const { coverArtPath } = c.req.query();
|
|
if (!coverArtPath) return c.json({ url: null });
|
|
|
|
try {
|
|
const { createMusicStorage } = await import('@mana/shared-storage');
|
|
const storage = createMusicStorage();
|
|
const url = await storage.getDownloadUrl(coverArtPath, { expiresIn: 3600 });
|
|
return c.json({ url });
|
|
} catch {
|
|
return c.json({ url: null });
|
|
}
|
|
});
|
|
|
|
// ─── Batch Cover URLs ───────────────────────────────────────
|
|
|
|
routes.post('/library/cover-urls', async (c) => {
|
|
const { paths } = await c.req.json();
|
|
if (!paths?.length) return c.json({ urls: {} });
|
|
|
|
try {
|
|
const { createMusicStorage } = await import('@mana/shared-storage');
|
|
const storage = createMusicStorage();
|
|
const urls: Record<string, string> = {};
|
|
|
|
for (const path of paths.slice(0, 50)) {
|
|
try {
|
|
urls[path] = await storage.getDownloadUrl(path, { expiresIn: 3600 });
|
|
} catch {
|
|
// Skip failed URLs
|
|
}
|
|
}
|
|
|
|
return c.json({ urls });
|
|
} catch {
|
|
return c.json({ urls: {} });
|
|
}
|
|
});
|
|
|
|
export { routes as musicRoutes };
|