mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-15 04:01:09 +02:00
259f6fb316
Regression reported in testing: tasks and calendar events created via
the Workbench homepage widgets appeared there but vanished from their
respective module sub-routes (/todo, /calendar).
Root cause: my M4.b + M4.a shipped `defaultVisibilityFor('personal') →
'private'` based on the original plan ("personal space default is
private"). That collides with the pre-existing 2-tier visibility filter
in `apps/mana/apps/web/src/lib/data/scope/visibility.ts`, which treats
'private' records as "only the authorId sees them, even inside the
same space". Its applyVisibility() drops any 'private' record whose
authorId doesn't exactly match getCurrentUserId() — and the homepage-
widget cross-app queries in cross-app-queries.ts don't run that filter
while /todo/useAllTasks() does, creating the asymmetry the user saw.
Why the match can fail in practice: during auth bootstrap,
getEffectiveUserId() returns the 'guest' sentinel (which the Dexie
creating-hook stamps onto authorId), while getCurrentUserId() can
already resolve to the real user id by the time /todo's query runs.
authorId='guest' !== currentUserId=<real> → record filtered out.
Fix: defaultVisibilityFor() now returns 'space' regardless of space
type. Rationale:
- In a personal space there's exactly one member, so 'space' and
'private' are effectively equivalent — both mean "only the owner
sees it".
- In a multi-member space, 'space' is the desired default (otherwise
every collaborative record would need a manual toggle).
- 'private' becomes an *active* user decision for drafts in shared
spaces — click the VisibilityPicker to enable it.
- The parameter is retained (as `_spaceType`) for forward-compat so
future space types can differentiate without touching call sites.
Impact on shipped modules: all 8 consumers (Library, Picture,
Calendar, Todo, Goals, Places, Recipes, Wardrobe) call
defaultVisibilityFor(activeSpace.type) at create time — they inherit
the fix automatically. No store edits required.
Existing records with visibility='private' from the testing window
stay as they are; user can flip them to 'Bereich' via the
VisibilityPicker, or reset the local Dexie to pick up the new default.
Plan doc updated with the full rationale (docs/plans/
visibility-system.md §Entscheidung).
Verified:
- pnpm test @mana/shared-privacy: 15/15 (defaults.test.ts updated)
- pnpm check (web): 7464 files, 0 errors
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
27 lines
996 B
TypeScript
27 lines
996 B
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { defaultVisibilityFor } from './defaults';
|
|
|
|
describe('defaultVisibilityFor', () => {
|
|
// 'space' everywhere so the default stays compatible with the
|
|
// existing 2-tier `applyVisibility` filter in scope/visibility.ts.
|
|
// See the function's doc comment for the full rationale.
|
|
it('returns space for personal space', () => {
|
|
expect(defaultVisibilityFor('personal')).toBe('space');
|
|
});
|
|
|
|
it('returns space for multi-member types', () => {
|
|
expect(defaultVisibilityFor('team')).toBe('space');
|
|
expect(defaultVisibilityFor('club')).toBe('space');
|
|
expect(defaultVisibilityFor('firma')).toBe('space');
|
|
});
|
|
|
|
it('returns space for unknown types', () => {
|
|
expect(defaultVisibilityFor('band')).toBe('space');
|
|
});
|
|
|
|
it('returns space when space type is missing', () => {
|
|
expect(defaultVisibilityFor(null)).toBe('space');
|
|
expect(defaultVisibilityFor(undefined)).toBe('space');
|
|
expect(defaultVisibilityFor('')).toBe('space');
|
|
});
|
|
});
|