managarten/packages/shared-ai/src/field-meta.ts
Till JS ad5e04a554 feat(sync): F2 — origin-gated conflict-detection
Closes the false-positive conflict-toast loop on history-replay. Conflict
notifications now fire only when the local field meta records origin='user'
AND the pull is not an initial hydration round.

Origin source-of-truth:
- shared-ai/field-meta.ts → originFromActor(actor) maps actor.kind onto
  the FieldOrigin enum: user→'user', ai→'agent', system+SYSTEM_MIGRATION
  →'migration', any other system source→'system'.
- Dexie creating/updating hooks call it once per write so every persisted
  field carries the right pipeline tag.
- repair-silent-twin + legacy-avatar wrap their writes in
  runAsAsync(makeSystemActor(SYSTEM_MIGRATION, ...)) so the hook stamps
  origin='migration'. Future replays of those rows from another device
  will not surface as conflicts.

applyServerChanges options:
- New ApplyServerChangesOptions { isInitialHydration?: boolean }.
- Push-response and pull-paged-loop callers compute it from the cursor
  state (`!oldestCursor` / `!cursor`). Pagination resets the flag after
  the first page.
- Conflict-trigger gates on `!options.isInitialHydration && localMeta[k]
  ?.origin === 'user'` in addition to the prior tests.

Tests (sync.test.ts):
- New: replay-burst (10 sequential server updates → 0 conflicts)
- New: agent-origin local write + server overwrite → 0 conflicts
- New: isInitialHydration suppresses everything → 0 conflicts
- New: real user edit + server overwrite → 1 conflict
- All 25 prior tests still pass.

29/29 vitest sync.test.ts cases green; svelte-check 0 errors over 7647
files.

Plan: docs/plans/sync-field-meta-overhaul.md F2 done-criteria met.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-26 21:38:56 +02:00

90 lines
3.7 KiB
TypeScript

/**
* Per-field write metadata — the unified replacement for the older
* triple of `__fieldTimestamps` + `__fieldActors` + `__lastActor`.
*
* Every synced record carries one `__fieldMeta` map, keyed by user-data
* field name. Each entry records:
*
* - `at` — ISO timestamp of the write (drives field-LWW ordering)
* - `actor` — who wrote it (drives Workbench attribution + revert)
* - `origin` — from what kind of pipeline the value came (drives
* conflict-detection: only `'user'`-origin writes can
* lose to a server overwrite)
*
* The "who" and the "from where" are separate concerns deliberately:
* an AI agent (`actor.kind === 'ai'`) writes with `origin === 'agent'`
* during normal operation, but the SAME agent's writes arrive at OTHER
* clients as `origin === 'server-replay'`. The actor identity travels
* unchanged; the origin describes the pipeline this particular client
* saw the value through.
*
* Lives in shared-ai because both runtimes (browser + mana-ai service)
* read and write the same shape.
*/
import type { Actor } from './actor';
import { SYSTEM_MIGRATION } from './actor';
/**
* Pipeline that produced a given field value, from the perspective of
* the local client that holds the record.
*
* - `'user'` — direct user edit through a module store
* - `'agent'` — write performed by an AI agent (mission runner
* or tool executor); the value originated locally
* - `'system'` — system bootstrap (singleton creation, projection,
* rule cascade)
* - `'migration'` — one-shot data-migration write (Dexie upgrade,
* repair routine)
* - `'server-replay'` — value applied from a mana-sync pull; never
* represents a local edit and therefore never
* triggers conflict-detection
*/
export type FieldOrigin = 'user' | 'agent' | 'system' | 'migration' | 'server-replay';
/**
* One entry in a record's `__fieldMeta` map. Frozen by the factory so
* downstream consumers can pass the same object to multiple fields
* without worrying about accidental mutation.
*/
export interface FieldMeta {
readonly at: string;
readonly actor: Actor;
readonly origin: FieldOrigin;
}
/** Build a frozen FieldMeta entry. Prefer this over inline object
* literals so the read-side never sees a half-populated entry. */
export function makeFieldMeta(at: string, actor: Actor, origin: FieldOrigin): FieldMeta {
return Object.freeze({ at, actor, origin });
}
/** True iff a field write may be overwritten silently by a server pull
* without surfacing a conflict toast. Server-replay, system, and
* migration writes are pipeline-internal — the user never typed them
* and therefore can't "lose" them. Agent writes lose silently too:
* they are visible separately via the proposal/mission UI, not via
* the conflict toast. */
export function isUserOriginatedField(meta: FieldMeta | undefined): boolean {
return meta?.origin === 'user';
}
/**
* Map an actor onto the pipeline-origin we stamp at the Dexie hook.
*
* Rules:
* - `kind: 'user'` → `'user'`
* - `kind: 'ai'` → `'agent'`
* - `kind: 'system'` with `principalId === SYSTEM_MIGRATION` → `'migration'`
* - any other system source → `'system'`
*
* Server-replay is set explicitly by `applyServerChanges`, never derived
* here — the local hook only sees writes the local code initiated.
*/
export function originFromActor(actor: Actor): FieldOrigin {
if (actor.kind === 'ai') return 'agent';
if (actor.kind === 'system') {
return actor.principalId === SYSTEM_MIGRATION ? 'migration' : 'system';
}
return 'user';
}