mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-14 19:01:08 +02:00
2bbcf14aba
Pelias was retired from the Mac mini on 2026-04-28; photon-self (self-hosted Photon on mana-gpu) has been the live primary since then. This removes the now-dead Pelias adapter, config, tests, and the services/mana-geocoding/pelias/ stack — the entire compose file, the geojsonify_place_details.js patch, the setup.sh import script. Provider chain is now `photon-self → photon → nominatim`. The chain keeps its `privacy: 'local' | 'public'` split, sensitive-query blocking, coord quantization, and aggressive caching unchanged. Three direct calls to nominatim.openstreetmap.org that bypassed mana-geocoding now route through the wrapper: - citycorners/add-city + citycorners/cities/[slug]/add use the shared searchAddress() client (browser → same-origin proxy → mana-geocoding → photon-self). - memoro mobile drops its OSM reverse-geocoding fallback entirely; Expo's on-device reverse-geocoding stays as the sole path. Routing through the wrapper would require a memoro-server proxy endpoint — a follow-up if Expo's quality proves insufficient. Other behavioral changes: - CACHE_PUBLIC_TTL_MS dropped from 7d → 1h. The long TTL was a privacy-amplification trick from the Pelias era; with photon-self serving the bulk of traffic, a transient cross-LAN blip was pinning cached fallback answers for days. 1h gives quick recovery. - /health/pelias renamed to /health/photon-self; prometheus blackbox config + status-page generator updated. - mana-geocoding container no longer needs `extra_hosts: host.docker.internal:host-gateway` (was only there for the Pelias-on-host-network era). 113 tests passing. CLAUDE.md rewritten to reflect the post-Pelias architecture. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
96 lines
3.1 KiB
TypeScript
96 lines
3.1 KiB
TypeScript
/**
|
|
* Tests for the chain wiring in `createChain()`. The behavioral assertions
|
|
* here are the migration-critical ones — make sure that:
|
|
* - `photon-self` is registered iff `PHOTON_SELF_API_URL` is set
|
|
* - `photon-self` carries `privacy: 'local'` (eligible for sensitive queries)
|
|
* - the public `photon` slot stays `privacy: 'public'`
|
|
* - chain order is honored (self before public)
|
|
*/
|
|
|
|
import { describe, expect, it } from 'bun:test';
|
|
import { createChain } from '../app';
|
|
import type { Config } from '../config';
|
|
|
|
function baseConfig(overrides: Partial<Config> = {}): Config {
|
|
return {
|
|
port: 3018,
|
|
photon: { apiUrl: 'https://photon.komoot.io' },
|
|
photonSelf: { apiUrl: undefined },
|
|
nominatim: {
|
|
apiUrl: 'https://nominatim.openstreetmap.org',
|
|
userAgent: 'test',
|
|
intervalMs: 1100,
|
|
},
|
|
cors: { origins: [] },
|
|
cache: { maxEntries: 100, ttlMs: 1000, publicTtlMs: 7000 },
|
|
providers: {
|
|
enabled: ['photon-self', 'photon', 'nominatim'],
|
|
healthCacheMs: 30_000,
|
|
timeoutMs: 8000,
|
|
},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe('createChain — photon-self registration', () => {
|
|
it('does NOT register photon-self when PHOTON_SELF_API_URL is unset', () => {
|
|
const chain = createChain(baseConfig());
|
|
const snapshot = chain.getHealthSnapshot();
|
|
const names = snapshot.map((p) => p.name);
|
|
expect(names).not.toContain('photon-self');
|
|
});
|
|
|
|
it('registers photon-self when PHOTON_SELF_API_URL is set', () => {
|
|
const chain = createChain(
|
|
baseConfig({
|
|
photonSelf: { apiUrl: 'http://192.168.178.11:2322' },
|
|
})
|
|
);
|
|
const snapshot = chain.getHealthSnapshot();
|
|
const names = snapshot.map((p) => p.name);
|
|
expect(names).toContain('photon-self');
|
|
});
|
|
|
|
it('honors order: photon-self before public photon when both are enabled', () => {
|
|
const chain = createChain(
|
|
baseConfig({
|
|
photonSelf: { apiUrl: 'http://192.168.178.11:2322' },
|
|
providers: {
|
|
enabled: ['photon-self', 'photon', 'nominatim'],
|
|
healthCacheMs: 30_000,
|
|
timeoutMs: 8000,
|
|
},
|
|
})
|
|
);
|
|
const snapshot = chain.getHealthSnapshot();
|
|
// First entry is photon-self, then photon (public), then nominatim.
|
|
const names = snapshot.map((p) => p.name);
|
|
expect(names[0]).toBe('photon-self');
|
|
expect(names).toContain('photon');
|
|
expect(names).toContain('nominatim');
|
|
});
|
|
|
|
it('a stray empty PHOTON_SELF_API_URL does not register a useless provider', () => {
|
|
// The config loader trims and treats '' as undefined, but defend in
|
|
// depth — pass an explicit empty string here too.
|
|
const chain = createChain(baseConfig({ photonSelf: { apiUrl: undefined } }));
|
|
const names = chain.getHealthSnapshot().map((p) => p.name);
|
|
expect(names).not.toContain('photon-self');
|
|
});
|
|
|
|
it('photon-self is filtered to enabled list (drop if not in GEOCODING_PROVIDERS)', () => {
|
|
const chain = createChain(
|
|
baseConfig({
|
|
photonSelf: { apiUrl: 'http://192.168.178.11:2322' },
|
|
providers: {
|
|
// User explicitly excludes photon-self via env-var
|
|
enabled: ['photon', 'nominatim'],
|
|
healthCacheMs: 30_000,
|
|
timeoutMs: 8000,
|
|
},
|
|
})
|
|
);
|
|
const names = chain.getHealthSnapshot().map((p) => p.name);
|
|
expect(names).not.toContain('photon-self');
|
|
});
|
|
});
|