till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 23:41:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(shared-error-tracking): point main at src/, strip dashes from Glitchtip DSN

Browse source 
Two real-world fixes from wiring mana-auth to Glitchtip:

1. The compiled dist/ folder was excluded from Docker builds via
   .dockerignore's '**/dist' rule, so any container that pnpm-installed
   the package found node_modules/@mana/shared-error-tracking but no
   loadable entry point ('Cannot find module' at startup). Match the
   pattern shared-hono uses — point main + types + exports straight at
   src/*.ts. Bun runs TS natively and the type-only consumers don't
   care.

2. Glitchtip projects expose UUID-format public keys (`556fbd2e-a720-…`)
   in their generated DSNs. @sentry/node v9 tightened its DSN regex to
   alphanumeric-only, so it silently rejects the DSN with "Invalid
   Sentry Dsn" and never sends events. Strip the dashes from the
   user/key portion before handing it to Sentry — the Glitchtip ingest
   endpoint accepts both forms over the wire, so no server change.

Plus the missing Dockerfile COPY lines for shared-error-tracking and
eslint-config (root package.json devDeps reference the latter, which
breaks pnpm-filter installs that don't include it in the build context).

Verified end-to-end: 4 issues now in Glitchtip from mana-auth
(2 manual probes + 1 captureException + 1 401 from a
real /api/v1/me/data request without auth).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-05-07 02:34:54 +02:00
parent 1bac7cf38a
commit f422fd6779
3 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/shared-error-tracking/src/index.ts
View file

@ -46,15 +46,23 @@ let initialized = false;
export function initErrorTracking(options: ErrorTrackingOptions): void {
if (initialized) return;
const dsn = options.dsn || process.env.GLITCHTIP_DSN || process.env.SENTRY_DSN;
const rawDsn = options.dsn || process.env.GLITCHTIP_DSN || process.env.SENTRY_DSN;
if (!dsn) {
if (!rawDsn) {
if (options.debug) {
console.log(`[ErrorTracking] No DSN configured for ${options.serviceName} - disabled`);
}
return;
}
// Glitchtip projects use UUID-format public_keys (`556fbd2e-a720-...`)
// but @sentry/node v9's DSN parser only accepts alphanumeric — dashes
// trip "Invalid Sentry Dsn" and silently disable transport. Strip them
// from the user/key portion only; the wire format accepts both.
const dsn = rawDsn.replace(/^(https?:\/\/)([\w-]+)(@.+)$/, (_, proto, key, rest) => {
return proto + key.replace(/-/g, '') + rest;
});
Sentry.init({
dsn,
environment: options.environment || process.env.NODE_ENV || 'development',