From f2faaf138729ceda1435cebb4c4048ef56f2e3e9 Mon Sep 17 00:00:00 2001 From: Till JS Date: Wed, 15 Apr 2026 21:43:29 +0200 Subject: [PATCH] refactor(pill-nav): drop Settings entry, guard on settingsHref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Settings lives in the Workbench now — no longer needs its own pill. settingsHref becomes optional; both places that render the entry (user-menu link list + nav overflow dropdown) skip it when unset. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../apps/web/src/routes/(app)/+layout.svelte | 1 - .../src/navigation/PillNavigation.svelte | 18 ++++++++++-------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/apps/mana/apps/web/src/routes/(app)/+layout.svelte b/apps/mana/apps/web/src/routes/(app)/+layout.svelte index 1711fb2ec..4462e029b 100644 --- a/apps/mana/apps/web/src/routes/(app)/+layout.svelte +++ b/apps/mana/apps/web/src/routes/(app)/+layout.svelte @@ -974,7 +974,6 @@ currentSyncLabel={syncStatus.label} {appItems} {userEmail} - settingsHref="/" manaHref="/mana" profileHref="/profile" spiralHref="/spiral" diff --git a/packages/shared-ui/src/navigation/PillNavigation.svelte b/packages/shared-ui/src/navigation/PillNavigation.svelte index ba5428139..a502955ae 100644 --- a/packages/shared-ui/src/navigation/PillNavigation.svelte +++ b/packages/shared-ui/src/navigation/PillNavigation.svelte @@ -379,7 +379,7 @@ appItems = [], showAppSwitcher = false, userEmail, - settingsHref = '/settings', + settingsHref, manaHref, profileHref, loginHref, @@ -476,13 +476,15 @@ active: currentPath === profileHref, }); } - links.push({ - id: 'settings', - label: 'Einstellungen', - icon: 'settings', - href: settingsHref, - active: currentPath === settingsHref, - }); + if (settingsHref) { + links.push({ + id: 'settings', + label: 'Einstellungen', + icon: 'settings', + href: settingsHref, + active: currentPath === settingsHref, + }); + } if (userEmail && manaHref) { links.push({ id: 'mana',