till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 20:01:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(ai): bubble proposal-reject feedback into Mission iteration

Browse source 
The Planner reads `mission.iterations[].userFeedback` — not
`pendingProposals.userFeedback` — so feedback stored only on the
proposal row never reached the next plan. rejectProposal now also
appends to the matching iteration's `userFeedback` (merging with any
existing reasons via "\n· " bullets) when the proposal carries
missionId + iterationId.

Lazy imports the mission store to avoid a proposal↔mission cycle.
Best-effort: proposal rejection still succeeds even if the bubble fails.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-15 00:57:25 +02:00
parent 98547b9e4e
commit ce646550cd
1 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

23
apps/mana/apps/web/src/lib/data/ai/proposals/store.ts
View file

@ -101,6 +101,29 @@ export async function rejectProposal(id: string, userFeedback?: string): Promise
userFeedback,
};
await table().update(id, updated);
// Bubble the feedback up to the Mission iteration so the next Planner
// pass (which reads `mission.iterations[].userFeedback` — NOT
// `pendingProposals.userFeedback`) can course-correct. Lazy-import
// to avoid a cycle: mission store ↔ proposal store.
if (userFeedback && proposal.missionId && proposal.iterationId) {
try {
const { addIterationFeedback, getMission } = await import('../missions/store');
const mission = await getMission(proposal.missionId);
// Merge with any existing feedback on the iteration — different
// steps within one iteration can produce different reasons.
const existingIt = mission?.iterations.find((it) => it.id === proposal.iterationId);
const merged = existingIt?.userFeedback
? `${existingIt.userFeedback}\n· ${userFeedback}`
: userFeedback;
await addIterationFeedback(proposal.missionId, proposal.iterationId, merged);
} catch (err) {
// Feedback bubble is best-effort — the proposal was still
// rejected successfully if this fails.
console.error('[rejectProposal] failed to bubble feedback to iteration:', err);
}
}
return { ...proposal, ...updated };
}