till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-22 01:02:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(packages): modal keydown handlers, $derived.by usage, UserData fields

Browse source 
Eight more package-level type errors that all came from the same
small handful of patterns.

Modal escape-key handlers calling click-style functions
  Four modals (AuthGateModal, GuestWelcomeModal, ConfirmationPopover,
  ShareModal) had `onkeydown={(e) => { if (e.key === 'Escape')
  handleBackdropClick(); }}` — but handleBackdropClick took a MouseEvent
  parameter, so the no-arg call failed with "Expected 1 arguments,
  got 0". Fix: route the keyboard escape path through the right
  no-arg helper (`onClose` / `handleClose` / `handleContinueAsGuest`)
  or pass the keyboard event through with a cast for the popover
  trigger that genuinely shares its handler with the click path.

WallpaperModal $derived
  `currentLayout` and `currentBackground` were declared with
  `$derived(() => {...})` — passing a function expression. The
  variant that takes a thunk is `$derived.by(...)`; plain `$derived`
  expects a single value expression. Result: the variables held the
  arrow function itself, the call sites had to invoke them as
  `currentLayout()`, and TS rejected the function value where Layout
  was expected. Switch to `$derived.by`, drop the call-site parens.

TagList.svelte
  Generic param was named `Tag` in the handler signature
  (`tag: Tag`) but the imported type was aliased as `TagType`. Tag
  was undefined → "Cannot find name 'Tag'". Renamed to TagType.

TagStrip.svelte
  `dropAccepts?: string[]` is too wide for `passiveDropZone`'s
  `accepts: DragType[]`. Narrowed the prop type to `DragType[]`
  and added the missing import.

shared-auth/types: UserData.{name,image}?
  Two more optional fields for the public user shape. Both come
  from the JWT user_metadata claim when the user has filled in
  their profile during onboarding. Without these the
  ProfileStep.svelte onboarding component couldn't read
  `authStore.user?.name` / `?.image` without `as any`. Added
  alongside `twoFactorEnabled` from the previous shared-auth
  commit; same Optional rationale (guest tokens omit the claim).

Net: -10 type errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-09 20:24:05 +02:00
parent ab24db36dd
commit c31ce4448f
8 changed files with 26 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/shared-ui/src/navigation/TagStrip.svelte
View file

@ -3,7 +3,7 @@
import { Tag, Plus, X } from '@mana/shared-icons';
import { dragSource } from '../dnd/drag-source';
import { passiveDropZone } from '../dnd/passive-drop';
import type { DragPayload } from '../dnd/types';
import type { DragPayload, DragType } from '../dnd/types';
interface TagItem {
id: string;
@ -23,7 +23,7 @@
/** Called when an item (task, card, etc.) is dropped on a tag pill */
onTagDrop?: (tagId: string, payload: DragPayload) => void;
/** Drag types accepted for drop-on-tag (default: ['task']) */
dropAccepts?: string[];
dropAccepts?: DragType[];
/** Link for "Tags verwalten" pill */
managementHref?: string;
/** Loading state */