From b3541957bdf25b1a043ae30301295e07b8729598 Mon Sep 17 00:00:00 2001
From: Till JS <tills95@gmail.com>
Date: Tue, 31 Mar 2026 13:15:31 +0200
Subject: [PATCH] refactor(contacts): apply getErrorMessage helper to remaining
 files

Replace inline `e instanceof Error ? e.message : '...'` pattern
with getErrorMessage() in ContactList (3x) and ContactDetailModal (6x).
All contacts error handling now uses the shared utility.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../src/lib/components/ContactDetailModal.svelte    | 13 +++++++------
 .../apps/web/src/lib/components/ContactList.svelte  |  7 ++++---
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/apps/contacts/apps/web/src/lib/components/ContactDetailModal.svelte b/apps/contacts/apps/web/src/lib/components/ContactDetailModal.svelte
index 2cb384cd2..bec6c94cc 100644
--- a/apps/contacts/apps/web/src/lib/components/ContactDetailModal.svelte
+++ b/apps/contacts/apps/web/src/lib/components/ContactDetailModal.svelte
@@ -9,6 +9,7 @@
 	import SocialMediaFields from './forms/SocialMediaFields.svelte';
 	import DateFields from './forms/DateFields.svelte';
 	import SocialMediaLinks from './SocialMediaLinks.svelte';
+	import { getErrorMessage } from '$lib/utils/error-helpers';
 	import {
 		X,
 		PencilSimple,
@@ -136,7 +137,7 @@
 			contact = await contactsApi.get(contactId);
 			populateForm();
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler beim Laden des Kontakts';
+			error = getErrorMessage(e, 'Fehler beim Laden des Kontakts');
 		} finally {
 			loading = false;
 		}
@@ -179,7 +180,7 @@
 			});
 			editing = false;
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler beim Speichern';
+			error = getErrorMessage(e, 'Fehler beim Speichern');
 		} finally {
 			saving = false;
 		}
@@ -192,7 +193,7 @@
 			await contactsApi.delete(contactId);
 			onClose();
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler beim Löschen';
+			error = getErrorMessage(e, 'Fehler beim Löschen');
 			deleting = false;
 		}
 	}
@@ -203,7 +204,7 @@
 		try {
 			contact = await contactsApi.toggleFavorite(contactId);
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler';
+			error = getErrorMessage(e, 'Fehler');
 		}
 	}
 
@@ -235,7 +236,7 @@
 			const result = await photoApi.upload(contactId, file);
 			contact = { ...contact, photoUrl: result.photoUrl };
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler beim Hochladen';
+			error = getErrorMessage(e, 'Fehler beim Hochladen');
 		} finally {
 			uploadingPhoto = false;
 			// Reset input to allow re-selecting same file
@@ -254,7 +255,7 @@
 			await photoApi.delete(contactId);
 			contact = { ...contact, photoUrl: null };
 		} catch (e) {
-			error = e instanceof Error ? e.message : 'Fehler beim Löschen';
+			error = getErrorMessage(e, 'Fehler beim Löschen');
 		} finally {
 			uploadingPhoto = false;
 		}
diff --git a/apps/contacts/apps/web/src/lib/components/ContactList.svelte b/apps/contacts/apps/web/src/lib/components/ContactList.svelte
index f2e41e053..51c52f5a6 100644
--- a/apps/contacts/apps/web/src/lib/components/ContactList.svelte
+++ b/apps/contacts/apps/web/src/lib/components/ContactList.svelte
@@ -2,6 +2,7 @@
 	import { getContext } from 'svelte';
 	import { _ } from 'svelte-i18n';
 	import { Heart, Archive, Trash } from '@manacore/shared-icons';
+	import { getErrorMessage } from '$lib/utils/error-helpers';
 	import { contactsStore } from '$lib/stores/contacts.svelte';
 	import { viewModeStore } from '$lib/stores/view-mode.svelte';
 	import { contactsFilterStore } from '$lib/stores/filter.svelte';
@@ -188,7 +189,7 @@
 			selectedIds = new Set();
 			selectionMode = false;
 		} catch (e) {
-			toastStore.error(e instanceof Error ? e.message : 'Fehler beim Löschen');
+			toastStore.error(getErrorMessage(e, 'Fehler beim Löschen'));
 		} finally {
 			batchLoading = false;
 		}
@@ -204,7 +205,7 @@
 			selectedIds = new Set();
 			selectionMode = false;
 		} catch (e) {
-			toastStore.error(e instanceof Error ? e.message : 'Fehler beim Archivieren');
+			toastStore.error(getErrorMessage(e, 'Fehler beim Archivieren'));
 		} finally {
 			batchLoading = false;
 		}
@@ -220,7 +221,7 @@
 			selectedIds = new Set();
 			selectionMode = false;
 		} catch (e) {
-			toastStore.error(e instanceof Error ? e.message : 'Fehler');
+			toastStore.error(getErrorMessage(e, 'Fehler'));
 		} finally {
 			batchLoading = false;
 		}