From ab24db36ddf45755e59018c4d611b2ec649b10ca Mon Sep 17 00:00:00 2001
From: Till JS <tills95@gmail.com>
Date: Thu, 9 Apr 2026 20:23:34 +0200
Subject: [PATCH] fix(packages): cross-package broken imports + missing exports
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Five unrelated packages each had a few imports pointing at the wrong
file or missing from their public surface. Grouped because none of
the individual fixes warrants its own commit and they all unblock
the same downstream consumer (apps/mana/apps/web type-check).

packages/help
  - HelpPage.svelte: `'../types.js'` and `'./content'` for
    HelpPageProps/HelpSection/SearchResult — neither path exists.
    Real homes are `../ui-types` (props) and `../search-types`
    (search shapes). Fix the imports.
  - HelpSearch.svelte: same `'../content'` typo for SearchResult →
    `'../search-types'`.
  - translations.ts: `'./types.js'` for HelpPageTranslations →
    `'./ui-types'`.
  - ui-types.ts: was importing SearchResult from `'./content'` but
    that module only exports content shapes. Split into two imports
    so HelpContent stays from content.ts and SearchResult comes from
    search-types.ts.

packages/feedback
  - FeedbackPage.svelte: imported `Feedback` and `CreateFeedbackInput`
    from `'./createFeedbackService'` but the service module only
    exports the service factory. Real homes are `'./feedback'`
    (Feedback) and `'./api'` (CreateFeedbackInput).
  - FeedbackForm.svelte: same `'./feedback'` typo for
    CreateFeedbackInput → `'./api'`.

packages/subscriptions
  - UsageCard / CostCard / pages/SubscriptionPage: all imported
    UsageData / CostItem from `'./plans'` but those types live in
    `'./usage'`. SubscriptionPage additionally had a relative-path
    bug — it's at `src/pages/`, not `src/`, so `./plans` resolved
    to `pages/plans` (nonexistent). Now imports `'../plans'` for
    plan types and `'../usage'` for usage/cost types.

packages/shared-ui
  - index.ts: re-exports the QuickInputItem family from
    `./quick-input` but had forgotten `HighlightPattern`. Added.
    Apps that build their own InputBar pattern config (e.g.
    mana/web/src/lib/quick-input/types.ts) need it as a public type.
  - PillNavigation.svelte: imported `SpotlightAction` and
    `ContentSearcher` from `./GlobalSpotlight.svelte` (a Svelte
    component file), which only re-exports the default. Both types
    live in `./types`. Move them to the existing types-import
    block; the GlobalSpotlight import becomes a plain default.

packages/shared-auth-ui
  - stores/createAuthStore.svelte.ts: imported AuthServiceAdapter /
    AuthResult / BaseUser from `'./types'` (nonexistent — the file
    is `'./store-types'`).

Net: -23 type errors. Zero behavior change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 packages/feedback/src/FeedbackForm.svelte                | 2 +-
 packages/feedback/src/FeedbackPage.svelte                | 8 +++-----
 packages/help/src/components/HelpSearch.svelte           | 2 +-
 packages/help/src/pages/HelpPage.svelte                  | 4 ++--
 packages/help/src/translations.ts                        | 2 +-
 packages/help/src/ui-types.ts                            | 3 ++-
 .../shared-auth-ui/src/stores/createAuthStore.svelte.ts  | 2 +-
 packages/shared-ui/src/index.ts                          | 8 +++++++-
 packages/shared-ui/src/navigation/PillNavigation.svelte  | 7 +++----
 packages/subscriptions/src/CostCard.svelte               | 2 +-
 packages/subscriptions/src/UsageCard.svelte              | 2 +-
 packages/subscriptions/src/pages/SubscriptionPage.svelte | 9 ++-------
 12 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/packages/feedback/src/FeedbackForm.svelte b/packages/feedback/src/FeedbackForm.svelte
index 3896316ea..22f337729 100644
--- a/packages/feedback/src/FeedbackForm.svelte
+++ b/packages/feedback/src/FeedbackForm.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import type { CreateFeedbackInput } from './feedback';
+	import type { CreateFeedbackInput } from './api';
 
 	interface Props {
 		onSubmit: (input: CreateFeedbackInput) => Promise<void>;
diff --git a/packages/feedback/src/FeedbackPage.svelte b/packages/feedback/src/FeedbackPage.svelte
index 097c17ae2..10825389a 100644
--- a/packages/feedback/src/FeedbackPage.svelte
+++ b/packages/feedback/src/FeedbackPage.svelte
@@ -1,9 +1,7 @@
 <script lang="ts">
-	import type {
-		FeedbackService,
-		Feedback,
-		CreateFeedbackInput,
-	} from './createFeedbackService';
+	import type { FeedbackService } from './createFeedbackService';
+	import type { Feedback } from './feedback';
+	import type { CreateFeedbackInput } from './api';
 	import FeedbackForm from './FeedbackForm.svelte';
 	import FeedbackList from './FeedbackList.svelte';
 
diff --git a/packages/help/src/components/HelpSearch.svelte b/packages/help/src/components/HelpSearch.svelte
index e387eaf10..99981bdd9 100644
--- a/packages/help/src/components/HelpSearch.svelte
+++ b/packages/help/src/components/HelpSearch.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import type { HelpSearchProps } from '../ui-types';
-	import type { SearchResult } from '../content';
+	import type { SearchResult } from '../search-types';
 	import { createSearcher } from '../search-engine';
 
 	let { content, translations, placeholder, onResultSelect }: HelpSearchProps = $props();
diff --git a/packages/help/src/pages/HelpPage.svelte b/packages/help/src/pages/HelpPage.svelte
index 336b30cb5..dbe44af17 100644
--- a/packages/help/src/pages/HelpPage.svelte
+++ b/packages/help/src/pages/HelpPage.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
-	import type { HelpPageProps, HelpSection } from '../types.js';
-	import type { SearchResult } from './content';
+	import type { HelpPageProps, HelpSection } from '../ui-types';
+	import type { SearchResult } from '../search-types';
 	import HelpSearch from '../components/HelpSearch.svelte';
 	import FAQSection from '../components/FAQSection.svelte';
 	import FeaturesOverview from '../components/FeaturesOverview.svelte';
diff --git a/packages/help/src/translations.ts b/packages/help/src/translations.ts
index e6c116852..8fac37e70 100644
--- a/packages/help/src/translations.ts
+++ b/packages/help/src/translations.ts
@@ -3,7 +3,7 @@
  * Apps can use these directly or override individual fields.
  */
 
-import type { HelpPageTranslations } from './types.js';
+import type { HelpPageTranslations } from './ui-types';
 
 export const defaultTranslationsDE: HelpPageTranslations = {
 	title: 'Hilfe & Support',
diff --git a/packages/help/src/ui-types.ts b/packages/help/src/ui-types.ts
index 8878d4ad1..e3322a076 100644
--- a/packages/help/src/ui-types.ts
+++ b/packages/help/src/ui-types.ts
@@ -2,7 +2,8 @@
  * Component Props and Translation Types
  */
 
-import type { HelpContent, SearchResult } from './content';
+import type { HelpContent } from './content';
+import type { SearchResult } from './search-types';
 
 // ============================================================================
 // Translation Types
diff --git a/packages/shared-auth-ui/src/stores/createAuthStore.svelte.ts b/packages/shared-auth-ui/src/stores/createAuthStore.svelte.ts
index 7485e721a..b154cc6d9 100644
--- a/packages/shared-auth-ui/src/stores/createAuthStore.svelte.ts
+++ b/packages/shared-auth-ui/src/stores/createAuthStore.svelte.ts
@@ -15,7 +15,7 @@
  * ```
  */
 
-import type { AuthServiceAdapter, AuthResult, BaseUser } from './types';
+import type { AuthServiceAdapter, AuthResult, BaseUser } from './store-types';
 
 /**
  * Create a Svelte 5 runes-based auth store
diff --git a/packages/shared-ui/src/index.ts b/packages/shared-ui/src/index.ts
index e6624c60f..5878ff09d 100644
--- a/packages/shared-ui/src/index.ts
+++ b/packages/shared-ui/src/index.ts
@@ -183,7 +183,13 @@ export {
 	createInputBarSettingsStore,
 	getInputBarSettingsStore,
 } from './quick-input';
-export type { QuickInputItem, QuickAction, CreatePreview, InputBarSettings } from './quick-input';
+export type {
+	QuickInputItem,
+	QuickAction,
+	CreatePreview,
+	HighlightPattern,
+	InputBarSettings,
+} from './quick-input';
 
 // Pages
 export { default as AppsPage } from './pages/AppsPage.svelte';
diff --git a/packages/shared-ui/src/navigation/PillNavigation.svelte b/packages/shared-ui/src/navigation/PillNavigation.svelte
index 39af517ae..8f098c42f 100644
--- a/packages/shared-ui/src/navigation/PillNavigation.svelte
+++ b/packages/shared-ui/src/navigation/PillNavigation.svelte
@@ -7,15 +7,14 @@
 		PillTabGroupConfig,
 		PillTagSelectorConfig,
 		PillAppItem,
+		SpotlightAction,
+		ContentSearcher,
 	} from './types';
 	import PillDropdown from './PillDropdown.svelte';
 	import PillTabGroup from './PillTabGroup.svelte';
 	import PillTagSelector from './PillTagSelector.svelte';
 	import AppDrawer from './AppDrawer.svelte';
-	import GlobalSpotlight, {
-		type SpotlightAction,
-		type ContentSearcher,
-	} from './GlobalSpotlight.svelte';
+	import GlobalSpotlight from './GlobalSpotlight.svelte';
 	import { createGlobalSpotlightState } from './useGlobalSpotlight.svelte';
 	// Phosphor Icons (via shared-icons)
 	import {
diff --git a/packages/subscriptions/src/CostCard.svelte b/packages/subscriptions/src/CostCard.svelte
index 0ff2a8e9a..a6a761fba 100644
--- a/packages/subscriptions/src/CostCard.svelte
+++ b/packages/subscriptions/src/CostCard.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import type { CostItem } from './plans';
+	import type { CostItem } from './usage';
 
 	interface Props {
 		costs: CostItem[];
diff --git a/packages/subscriptions/src/UsageCard.svelte b/packages/subscriptions/src/UsageCard.svelte
index 0fd90ca74..e643f7a12 100644
--- a/packages/subscriptions/src/UsageCard.svelte
+++ b/packages/subscriptions/src/UsageCard.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import type { UsageData } from './plans';
+	import type { UsageData } from './usage';
 
 	interface Props {
 		title?: string;
diff --git a/packages/subscriptions/src/pages/SubscriptionPage.svelte b/packages/subscriptions/src/pages/SubscriptionPage.svelte
index 0fa267c92..f679aec1f 100644
--- a/packages/subscriptions/src/pages/SubscriptionPage.svelte
+++ b/packages/subscriptions/src/pages/SubscriptionPage.svelte
@@ -1,11 +1,6 @@
 <script lang="ts">
-	import type {
-		SubscriptionPlan,
-		ManaPackage,
-		UsageData,
-		CostItem,
-		BillingCycle,
-	} from './plans';
+	import type { SubscriptionPlan, ManaPackage, BillingCycle } from '../plans';
+	import type { UsageData, CostItem } from '../usage';
 	import BillingToggle from '../BillingToggle.svelte';
 	import SubscriptionCard from '../SubscriptionCard.svelte';
 	import PackageCard from '../PackageCard.svelte';