From 9b26caf5a141f401948eb65fcb30703d087dd83e Mon Sep 17 00:00:00 2001 From: Wuesteon Date: Thu, 4 Dec 2025 22:58:45 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(mana-core-auth):=20remove=20?= =?UTF-8?q?type-only=20imports=20from=20services=20and=20controllers?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed remaining NestJS dependency injection issues by converting type-only imports to regular imports for all injectable services used in controllers and service dependencies. Changes: - feedback.service.ts: Fixed AiService import (was causing "argument Function at index [1]" error) - auth.controller.ts: Fixed BetterAuthService import - feedback.controller.ts: Fixed FeedbackService import - credits.controller.ts: Fixed CreditsService import - settings.controller.ts: Fixed SettingsService import Root cause: Type-only imports (`import { type X }`) are erased at compile time, causing NestJS to fail dependency injection at runtime. All injectable classes must use regular imports. Verified locally: All modules initialize successfully without DI errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- services/mana-core-auth/src/auth/auth.controller.ts | 2 +- services/mana-core-auth/src/credits/credits.controller.ts | 2 +- services/mana-core-auth/src/feedback/feedback.controller.ts | 2 +- services/mana-core-auth/src/feedback/feedback.service.ts | 2 +- services/mana-core-auth/src/settings/settings.controller.ts | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/services/mana-core-auth/src/auth/auth.controller.ts b/services/mana-core-auth/src/auth/auth.controller.ts index 5a67d1a4d..40f3ff1c9 100644 --- a/services/mana-core-auth/src/auth/auth.controller.ts +++ b/services/mana-core-auth/src/auth/auth.controller.ts @@ -10,7 +10,7 @@ import { HttpCode, HttpStatus, } from '@nestjs/common'; -import { type BetterAuthService } from './services/better-auth.service'; +import { BetterAuthService } from './services/better-auth.service'; import { type RegisterDto } from './dto/register.dto'; import { type LoginDto } from './dto/login.dto'; import { type RefreshTokenDto } from './dto/refresh-token.dto'; diff --git a/services/mana-core-auth/src/credits/credits.controller.ts b/services/mana-core-auth/src/credits/credits.controller.ts index 7901b1cca..cc9866f28 100644 --- a/services/mana-core-auth/src/credits/credits.controller.ts +++ b/services/mana-core-auth/src/credits/credits.controller.ts @@ -1,5 +1,5 @@ import { Controller, Get, Post, Body, UseGuards, Query, ParseIntPipe, Param } from '@nestjs/common'; -import { type CreditsService } from './credits.service'; +import { CreditsService } from './credits.service'; import { JwtAuthGuard } from '../common/guards/jwt-auth.guard'; import { CurrentUser, type CurrentUserData } from '../common/decorators/current-user.decorator'; import { type UseCreditsDto } from './dto/use-credits.dto'; diff --git a/services/mana-core-auth/src/feedback/feedback.controller.ts b/services/mana-core-auth/src/feedback/feedback.controller.ts index 32ea1aad1..2487a060e 100644 --- a/services/mana-core-auth/src/feedback/feedback.controller.ts +++ b/services/mana-core-auth/src/feedback/feedback.controller.ts @@ -9,7 +9,7 @@ import { UseGuards, Headers, } from '@nestjs/common'; -import { type FeedbackService } from './feedback.service'; +import { FeedbackService } from './feedback.service'; import { JwtAuthGuard } from '../common/guards/jwt-auth.guard'; import { OptionalAuthGuard } from '../common/guards/optional-auth.guard'; import { CurrentUser, type CurrentUserData } from '../common/decorators/current-user.decorator'; diff --git a/services/mana-core-auth/src/feedback/feedback.service.ts b/services/mana-core-auth/src/feedback/feedback.service.ts index a17d342be..9ab86112c 100644 --- a/services/mana-core-auth/src/feedback/feedback.service.ts +++ b/services/mana-core-auth/src/feedback/feedback.service.ts @@ -4,7 +4,7 @@ import { eq, and, desc, sql, count } from 'drizzle-orm'; import { getDb } from '../db/connection'; import { userFeedback, feedbackVotes } from '../db/schema'; import { type CreateFeedbackDto, type FeedbackQueryDto } from './dto'; -import { type AiService } from '../ai/ai.service'; +import { AiService } from '../ai/ai.service'; @Injectable() export class FeedbackService { diff --git a/services/mana-core-auth/src/settings/settings.controller.ts b/services/mana-core-auth/src/settings/settings.controller.ts index 755482a97..e8c291090 100644 --- a/services/mana-core-auth/src/settings/settings.controller.ts +++ b/services/mana-core-auth/src/settings/settings.controller.ts @@ -1,5 +1,5 @@ import { Controller, Get, Patch, Delete, Body, Param, UseGuards } from '@nestjs/common'; -import { type SettingsService } from './settings.service'; +import { SettingsService } from './settings.service'; import { JwtAuthGuard } from '../common/guards/jwt-auth.guard'; import { CurrentUser, type CurrentUserData } from '../common/decorators/current-user.decorator'; import { type UpdateGlobalSettingsDto, type UpdateAppOverrideDto } from './dto';