From 9534d2996748fda636d3e1243629bc6206b7cccf Mon Sep 17 00:00:00 2001
From: Till JS <tills95@gmail.com>
Date: Fri, 3 Apr 2026 12:31:53 +0200
Subject: [PATCH] fix: revert client sync from per-app SSE to HTTP polling

Per-app SSE connections exhaust the browser's 6-connection-per-origin
limit, causing the app to hang on load. Reverted to HTTP polling for
both eager and lazy apps.

SSE server endpoint remains available for future use as a single unified
stream (one connection for all apps, similar to the old unified WebSocket).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 apps/manacore/apps/web/src/lib/data/sync.ts | 31 ++++++++++-----------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/apps/manacore/apps/web/src/lib/data/sync.ts b/apps/manacore/apps/web/src/lib/data/sync.ts
index 5f2720be8..1a9e885bd 100644
--- a/apps/manacore/apps/web/src/lib/data/sync.ts
+++ b/apps/manacore/apps/web/src/lib/data/sync.ts
@@ -78,7 +78,7 @@ export function createUnifiedSync(serverUrl: string, getToken: () => Promise<str
 	// ─── Lifecycle ──────────────────────────────────────────
 
 	function startAll(): void {
-		// Register all channels but only start eager ones immediately
+		// Register all channels
 		for (const [appId, tables] of Object.entries(SYNC_APP_MAP)) {
 			const channel: SyncChannelState = {
 				appId,
@@ -90,9 +90,11 @@ export function createUnifiedSync(serverUrl: string, getToken: () => Promise<str
 			channels.set(appId, channel);
 
 			if (EAGER_APPS.has(appId)) {
-				connectSSE(appId);
+				// Eager apps: use HTTP polling (SSE would exhaust browser's 6-connection limit)
+				pull(appId).catch(() => {});
+				channel.pullTimer = setInterval(() => pull(appId).catch(() => {}), PULL_INTERVAL);
 			}
-			// Lazy apps: no SSE until ensureAppSynced() is called
+			// Lazy apps: no pull until ensureAppSynced() is called
 		}
 
 		// Listen for online/offline
@@ -495,10 +497,11 @@ export function createUnifiedSync(serverUrl: string, getToken: () => Promise<str
 	function handleOnline() {
 		online = true;
 		setStatus('idle');
-		// Reconnect SSE streams for active channels
-		for (const [appId, channel] of channels) {
-			if (EAGER_APPS.has(appId) || channel.pullTimer) {
-				connectSSE(appId);
+		// Resume sync for active channels
+		for (const appId of channels.keys()) {
+			const channel = channels.get(appId);
+			if (channel?.pullTimer || EAGER_APPS.has(appId)) {
+				pull(appId).catch(() => {});
 			}
 		}
 	}
@@ -506,11 +509,6 @@ export function createUnifiedSync(serverUrl: string, getToken: () => Promise<str
 	function handleOffline() {
 		online = false;
 		setStatus('offline');
-		// Abort all SSE connections
-		for (const [, controller] of sseAbortControllers) {
-			controller.abort();
-		}
-		sseAbortControllers.clear();
 	}
 
 	function setStatus(s: SyncStatus) {
@@ -522,15 +520,14 @@ export function createUnifiedSync(serverUrl: string, getToken: () => Promise<str
 
 	/**
 	 * Ensure a lazy app's collections are synced (called on module navigation).
-	 * Connects SSE stream if not already active.
+	 * If already synced (has pullTimer), this is a no-op.
 	 */
 	function ensureAppSynced(appId: string): void {
 		const channel = channels.get(appId);
-		if (!channel) return;
-		// Already connected via SSE
-		if (sseAbortControllers.has(appId)) return;
+		if (!channel || channel.pullTimer) return;
 
-		connectSSE(appId);
+		pull(appId).catch(() => {});
+		channel.pullTimer = setInterval(() => pull(appId).catch(() => {}), PULL_INTERVAL);
 	}
 
 	return {