till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 21:41:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(mana-core-auth): use comma-separated redirect_urls for Better Auth OIDC

Browse source 
Better Auth's OIDC provider expects redirect_urls to be a comma-separated
string, not a JSON array. Updated seed script and schema documentation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Till-JS 2026-01-30 18:12:16 +01:00
parent 78a5002968
commit 8207d38ca5
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
services/mana-core-auth/src/db/schema/auth.schema.ts
View file

@ -135,7 +135,7 @@ export const oauthApplications = authSchema.table('oauth_applications', {
metadata: text('metadata'),
clientId: text('client_id').unique().notNull(),
clientSecret: text('client_secret').notNull(),
redirectURLs: text('redirect_urls').notNull(), // JSON array as text
redirectURLs: text('redirect_urls').notNull(), // Comma-separated URLs (Better Auth expects this format, NOT JSON)
type: text('type').notNull().default('web'), // web, native, spa
disabled: boolean('disabled').default(false).notNull(),
userId: text('user_id').references(() => users.id, { onDelete: 'cascade' }),

6
services/mana-core-auth/src/db/seeds/seed-oidc-clients.ts
View file

@ -62,7 +62,8 @@ async function seed() {
.update(oauthApplications)
.set({
clientSecret: synapseClientSecret,
redirectURLs: JSON.stringify(['https://matrix.mana.how/_synapse/client/oidc/callback']),
// Better Auth expects comma-separated string, NOT JSON array
redirectURLs: 'https://matrix.mana.how/_synapse/client/oidc/callback',
updatedAt: new Date(),
})
.where(eq(oauthApplications.clientId, 'synapse'));
@ -77,7 +78,8 @@ async function seed() {
icon: 'https://matrix.org/images/matrix-logo.svg',
clientId: 'synapse',
clientSecret: synapseClientSecret,
redirectURLs: JSON.stringify(['https://matrix.mana.how/_synapse/client/oidc/callback']),
// Better Auth expects comma-separated string, NOT JSON array
redirectURLs: 'https://matrix.mana.how/_synapse/client/oidc/callback',
type: 'web',
disabled: false,
metadata: JSON.stringify({