From 812a6f5090e8222f918cdaeb9ea1a50d36e1606b Mon Sep 17 00:00:00 2001
From: Till-JS <101404291+Till-JS@users.noreply.github.com>
Date: Wed, 10 Dec 2025 20:16:17 +0100
Subject: [PATCH] fix(todo): resolve type errors and update component props
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fix KanbanColumn to use DndEvent type from svelte-dnd-action
- Extend UpdateTaskDto and store updateTask method to support all task fields
- Add metadata type cast in +page.svelte for compatibility
- Create feedback service and update FeedbackPage to use new API
- Fix forgot-password page: rename handler to onForgotPassword, use titleForm
- Remove deprecated enableGoogle/enableApple props from RegisterPage

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 apps/todo/apps/web/src/lib/api/tasks.ts       | 12 ++++++--
 .../lib/components/kanban/KanbanColumn.svelte | 29 +++++++++----------
 .../apps/web/src/lib/services/feedback.ts     | 23 +++++++++++++++
 .../apps/web/src/lib/stores/tasks.svelte.ts   | 12 ++++++--
 .../apps/web/src/routes/(app)/+page.svelte    |  8 +++--
 .../src/routes/(app)/feedback/+page.svelte    | 17 ++---------
 .../(auth)/forgot-password/+page.svelte       |  6 ++--
 .../src/routes/(auth)/register/+page.svelte   |  2 --
 8 files changed, 69 insertions(+), 40 deletions(-)
 create mode 100644 apps/todo/apps/web/src/lib/services/feedback.ts

diff --git a/apps/todo/apps/web/src/lib/api/tasks.ts b/apps/todo/apps/web/src/lib/api/tasks.ts
index 8696ec407..85f126e84 100644
--- a/apps/todo/apps/web/src/lib/api/tasks.ts
+++ b/apps/todo/apps/web/src/lib/api/tasks.ts
@@ -14,13 +14,21 @@ interface CreateTaskDto {
 
 interface UpdateTaskDto {
 	title?: string;
-	description?: string;
+	description?: string | null;
 	projectId?: string | null;
+	parentTaskId?: string | null;
 	dueDate?: string | null;
+	dueTime?: string | null;
+	startDate?: string | null;
 	priority?: TaskPriority;
 	status?: TaskStatus;
-	subtasks?: Subtask[];
+	isCompleted?: boolean;
+	order?: number;
+	subtasks?: Subtask[] | null;
 	recurrenceRule?: string | null;
+	recurrenceEndDate?: string | null;
+	metadata?: Record<string, unknown> | null;
+	labelIds?: string[];
 }
 
 interface TaskQuery {
diff --git a/apps/todo/apps/web/src/lib/components/kanban/KanbanColumn.svelte b/apps/todo/apps/web/src/lib/components/kanban/KanbanColumn.svelte
index b3c216c74..8e366a5e2 100644
--- a/apps/todo/apps/web/src/lib/components/kanban/KanbanColumn.svelte
+++ b/apps/todo/apps/web/src/lib/components/kanban/KanbanColumn.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
-	import { dndzone, SHADOW_PLACEHOLDER_ITEM_ID } from 'svelte-dnd-action';
-	import type { KanbanColumn, Task, UpdateTaskInput } from '@todo/shared';
+	import { dndzone, SHADOW_PLACEHOLDER_ITEM_ID, type DndEvent } from 'svelte-dnd-action';
+	import type { KanbanColumn, Task } from '@todo/shared';
 	import KanbanTaskCard from './KanbanTaskCard.svelte';
 	import KanbanColumnHeader from './KanbanColumnHeader.svelte';
 	import QuickAddTaskInline from './QuickAddTaskInline.svelte';
@@ -36,13 +36,11 @@
 
 	const flipDurationMs = 200;
 
-	function handleDndConsider(e: CustomEvent<{ items: Task[] }>) {
+	function handleDndConsider(e: CustomEvent<DndEvent<Task>>) {
 		localTasks = e.detail.items;
 	}
 
-	function handleDndFinalize(
-		e: CustomEvent<{ items: Task[]; info: { id: string; source: { items: Task[] } } }>
-	) {
+	function handleDndFinalize(e: CustomEvent<DndEvent<Task>>) {
 		const newItems = e.detail.items.filter((t) => t.id !== SHADOW_PLACEHOLDER_ITEM_ID);
 		const movedTaskId = e.detail.info.id;
 
@@ -71,20 +69,21 @@
 		}
 	}
 
-	async function handleSaveTask(task: Task, data: UpdateTaskInput) {
-		// Transform data to match updateTask API (convert null to undefined)
-		const updateData: UpdateTaskInput = {};
+	async function handleSaveTask(task: Task, data: Partial<Task>) {
+		// Transform Partial<Task> to updateTask format
+		const updateData: Record<string, unknown> = {};
 		if (data.title !== undefined) updateData.title = data.title;
-		if (data.description !== undefined) updateData.description = data.description ?? undefined;
+		if (data.description !== undefined) updateData.description = data.description;
 		if (data.projectId !== undefined) updateData.projectId = data.projectId;
-		if (data.dueDate !== undefined) updateData.dueDate = data.dueDate ?? undefined;
+		if (data.dueDate !== undefined) {
+			updateData.dueDate = data.dueDate instanceof Date ? data.dueDate.toISOString() : data.dueDate;
+		}
 		if (data.priority !== undefined) updateData.priority = data.priority;
 		if (data.status !== undefined) updateData.status = data.status;
-		if (data.subtasks !== undefined) updateData.subtasks = data.subtasks ?? undefined;
-		if (data.recurrenceRule !== undefined)
-			updateData.recurrenceRule = data.recurrenceRule ?? undefined;
+		if (data.subtasks !== undefined) updateData.subtasks = data.subtasks;
+		if (data.recurrenceRule !== undefined) updateData.recurrenceRule = data.recurrenceRule;
 		if (data.metadata !== undefined) updateData.metadata = data.metadata;
-		if (data.labelIds !== undefined) updateData.labelIds = data.labelIds;
+		if (data.labels !== undefined) updateData.labelIds = data.labels?.map((l) => l.id);
 
 		await tasksStore.updateTask(task.id, updateData);
 	}
diff --git a/apps/todo/apps/web/src/lib/services/feedback.ts b/apps/todo/apps/web/src/lib/services/feedback.ts
new file mode 100644
index 000000000..54551cc3b
--- /dev/null
+++ b/apps/todo/apps/web/src/lib/services/feedback.ts
@@ -0,0 +1,23 @@
+/**
+ * Feedback Service Instance for Todo Web App
+ */
+
+import { browser } from '$app/environment';
+import { createFeedbackService } from '@manacore/shared-feedback-service';
+import { authStore } from '$lib/stores/auth.svelte';
+
+// Get auth URL dynamically at runtime
+function getAuthUrl(): string {
+	if (browser && typeof window !== 'undefined') {
+		const injectedUrl = (window as unknown as { __PUBLIC_MANA_CORE_AUTH_URL__?: string })
+			.__PUBLIC_MANA_CORE_AUTH_URL__;
+		return injectedUrl || 'http://localhost:3001';
+	}
+	return 'http://localhost:3001';
+}
+
+export const feedbackService = createFeedbackService({
+	apiUrl: getAuthUrl(),
+	appId: 'todo',
+	getAuthToken: async () => authStore.getAccessToken(),
+});
diff --git a/apps/todo/apps/web/src/lib/stores/tasks.svelte.ts b/apps/todo/apps/web/src/lib/stores/tasks.svelte.ts
index 0d88b54a4..913a38711 100644
--- a/apps/todo/apps/web/src/lib/stores/tasks.svelte.ts
+++ b/apps/todo/apps/web/src/lib/stores/tasks.svelte.ts
@@ -217,13 +217,21 @@ export const tasksStore = {
 		id: string,
 		data: {
 			title?: string;
-			description?: string;
+			description?: string | null;
 			projectId?: string | null;
+			parentTaskId?: string | null;
 			dueDate?: string | null;
+			dueTime?: string | null;
+			startDate?: string | null;
 			priority?: TaskPriority;
 			status?: TaskStatus;
-			subtasks?: Subtask[];
+			isCompleted?: boolean;
+			order?: number;
+			subtasks?: Subtask[] | null;
 			recurrenceRule?: string | null;
+			recurrenceEndDate?: string | null;
+			metadata?: { [key: string]: unknown } | null;
+			labelIds?: string[];
 		}
 	) {
 		error = null;
diff --git a/apps/todo/apps/web/src/routes/(app)/+page.svelte b/apps/todo/apps/web/src/routes/(app)/+page.svelte
index 65b7dcc71..f3c2eac78 100644
--- a/apps/todo/apps/web/src/routes/(app)/+page.svelte
+++ b/apps/todo/apps/web/src/routes/(app)/+page.svelte
@@ -100,8 +100,12 @@
 		if (!editingTask) return;
 
 		try {
-			// Update task
-			await tasksStore.updateTask(editingTask.id, data);
+			// Update task - cast metadata to be compatible with store type
+			const updateData = {
+				...data,
+				metadata: data.metadata as { [key: string]: unknown } | null | undefined,
+			};
+			await tasksStore.updateTask(editingTask.id, updateData);
 
 			// Update labels if provided
 			if (data.labelIds !== undefined) {
diff --git a/apps/todo/apps/web/src/routes/(app)/feedback/+page.svelte b/apps/todo/apps/web/src/routes/(app)/feedback/+page.svelte
index a77e17da1..13e82de6e 100644
--- a/apps/todo/apps/web/src/routes/(app)/feedback/+page.svelte
+++ b/apps/todo/apps/web/src/routes/(app)/feedback/+page.svelte
@@ -1,22 +1,11 @@
 <script lang="ts">
-	import { onMount } from 'svelte';
-	import { goto } from '$app/navigation';
-	import { authStore } from '$lib/stores/auth.svelte';
 	import { FeedbackPage } from '@manacore/shared-feedback-ui';
-
-	onMount(() => {
-		if (!authStore.isAuthenticated) {
-			goto('/login');
-		}
-	});
+	import { feedbackService } from '$lib/services/feedback';
+	import { authStore } from '$lib/stores/auth.svelte';
 </script>
 
 <svelte:head>
 	<title>Feedback | Todo</title>
 </svelte:head>
 
-<FeedbackPage
-	appName="Todo"
-	userEmail={authStore.user?.email || undefined}
-	primaryColor="#8b5cf6"
-/>
+<FeedbackPage {feedbackService} appName="Todo" currentUserId={authStore.user?.id} />
diff --git a/apps/todo/apps/web/src/routes/(auth)/forgot-password/+page.svelte b/apps/todo/apps/web/src/routes/(auth)/forgot-password/+page.svelte
index 671982a89..d1a66724d 100644
--- a/apps/todo/apps/web/src/routes/(auth)/forgot-password/+page.svelte
+++ b/apps/todo/apps/web/src/routes/(auth)/forgot-password/+page.svelte
@@ -11,20 +11,20 @@
 	// Get translations based on current locale
 	const translations = $derived(getForgotPasswordTranslations($locale || 'de'));
 
-	async function handleResetPassword(email: string) {
+	async function handleForgotPassword(email: string) {
 		return authStore.resetPassword(email);
 	}
 </script>
 
 <svelte:head>
-	<title>{translations.title} | Todo</title>
+	<title>{translations.titleForm} | Todo</title>
 </svelte:head>
 
 <ForgotPasswordPage
 	appName="Todo"
 	logo={TodoLogo}
 	primaryColor="#8b5cf6"
-	onResetPassword={handleResetPassword}
+	onForgotPassword={handleForgotPassword}
 	{goto}
 	loginPath="/login"
 	lightBackground="#f3e8ff"
diff --git a/apps/todo/apps/web/src/routes/(auth)/register/+page.svelte b/apps/todo/apps/web/src/routes/(auth)/register/+page.svelte
index 0002da9cf..b8f3c7963 100644
--- a/apps/todo/apps/web/src/routes/(auth)/register/+page.svelte
+++ b/apps/todo/apps/web/src/routes/(auth)/register/+page.svelte
@@ -26,8 +26,6 @@
 	primaryColor="#8b5cf6"
 	onSignUp={handleSignUp}
 	{goto}
-	enableGoogle={false}
-	enableApple={false}
 	successRedirect="/"
 	loginPath="/login"
 	lightBackground="#f3e8ff"