fix(apps): use explicit AuthServiceInterface in all 21 auth stores, re-enable type-check

Replace ReturnType<typeof initializeWebAuth>['authService'] with the
explicit AuthServiceInterface in all 21 web app auth stores. This
ensures svelte-check sees all 37 auth methods instead of TS inferring
a truncated type (~27 methods visible).

Re-enabled type-check in 5 apps that were skipping it:
- chat/web: svelte-kit sync && svelte-check --threshold error
- clock/web: svelte-kit sync && svelte-check --threshold error
- context/web: svelte-kit sync && svelte-check --threshold error
- presi/web: svelte-kit sync && svelte-check --threshold error
- picture/mobile: tsc --noEmit

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-03-28 10:15:23 +01:00
parent 5a9949f735
commit 79080d6654
24 changed files with 37 additions and 37 deletions

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -10,7 +10,7 @@
"prepare": "svelte-kit sync || echo ''",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"type-check": "echo 'Skipping type-check: @chat/web needs shared-ui component fixes'",
"type-check": "svelte-kit sync && svelte-check --threshold error",
"lint": "eslint ."
},
"devDependencies": {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -31,7 +31,7 @@ function getBackendUrl(): string {
return process.env.PUBLIC_BACKEND_URL || DEV_BACKEND_URL;
}
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -11,7 +11,7 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "eslint .",
"format": "prettier --write .",
"type-check": "echo 'Skipping type-check for now'"
"type-check": "svelte-kit sync && svelte-check --threshold error"
},
"devDependencies": {
"@manacore/shared-pwa": "workspace:*",

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -11,7 +11,7 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "eslint .",
"format": "prettier --write .",
"type-check": "echo 'Skipping type-check for now'"
"type-check": "svelte-kit sync && svelte-check --threshold error"
},
"devDependencies": {
"@manacore/shared-pwa": "workspace:*",

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -31,7 +31,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
const DEV_AUTH_URL = 'http://localhost:3001';
@ -18,7 +18,7 @@ function getAuthUrl(): string {
return process.env.PUBLIC_MANA_CORE_AUTH_URL || DEV_AUTH_URL;
}
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URL for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -21,7 +21,7 @@ function getAuthUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -32,7 +32,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -32,7 +32,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -32,7 +32,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -13,7 +13,7 @@
"prebuild": "expo prebuild",
"lint": "eslint .",
"format": "eslint . --fix",
"type-check": "echo 'Skipping type-check: @picture/mobile needs theme system migration'",
"type-check": "tsc --noEmit",
"postinstall": "patch-package || true && ./scripts/build-workspace-deps.sh"
},
"dependencies": {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -32,7 +32,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -8,7 +8,7 @@
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"type-check": "echo 'Skipping type-check: @presi/web needs shared-ui component fixes'",
"type-check": "svelte-kit sync && svelte-check --threshold error",
"lint": "eslint .",
"format": "prettier --write ."
},

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -31,7 +31,7 @@ function getBackendUrl(): string {
return process.env.PUBLIC_BACKEND_URL || DEV_BACKEND_URL;
}
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
import { apiClient } from '$lib/api/client';
const DEV_AUTH_URL = 'http://localhost:3001';
@ -30,7 +30,7 @@ function getBackendUrl(): string {
return process.env.PUBLIC_BACKEND_URL || DEV_BACKEND_URL;
}
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
import { apiClient } from '$lib/api/client';
import { todoStore } from '$lib/data/local-store';
@ -39,7 +39,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {

View file

@ -4,7 +4,7 @@
*/
import { browser } from '$app/environment';
import { initializeWebAuth, type UserData } from '@manacore/shared-auth';
import { initializeWebAuth, type UserData, type AuthServiceInterface } from '@manacore/shared-auth';
// Default URLs for local development only
const DEV_AUTH_URL = 'http://localhost:3001';
@ -33,7 +33,7 @@ function getBackendUrl(): string {
}
// Lazy initialization to avoid SSR issues with localStorage
let _authService: ReturnType<typeof initializeWebAuth>['authService'] | null = null;
let _authService: AuthServiceInterface | null = null;
let _tokenManager: ReturnType<typeof initializeWebAuth>['tokenManager'] | null = null;
function getAuthService() {