From 576fe79269916681dfbc6d783ad614a0d29d44c1 Mon Sep 17 00:00:00 2001 From: Till JS Date: Mon, 27 Apr 2026 00:25:35 +0200 Subject: [PATCH] fix(community): clear svelte-check warnings for fail-on-warnings push gate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reactive-state-locally + a11y-noninteractive-tabindex/element warnings. No behavior changes — props stay reactive via destructure-from-$props pattern, ignore-comments document intentional a11y exceptions. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../feedback/FeedbackQuickModal.svelte | 23 ++++++++----------- .../community/components/ItemCard.svelte | 1 + .../modules/community/views/DetailView.svelte | 6 ++--- .../modules/community/views/ListView.svelte | 6 ++--- 4 files changed, 17 insertions(+), 19 deletions(-) diff --git a/apps/mana/apps/web/src/lib/components/feedback/FeedbackQuickModal.svelte b/apps/mana/apps/web/src/lib/components/feedback/FeedbackQuickModal.svelte index f7534c4e7..e2bc11aac 100644 --- a/apps/mana/apps/web/src/lib/components/feedback/FeedbackQuickModal.svelte +++ b/apps/mana/apps/web/src/lib/components/feedback/FeedbackQuickModal.svelte @@ -23,16 +23,12 @@ title?: string; } - let { - open, - onClose, - moduleContext, - defaultCategory = 'feature', - title = 'Idee oder Feedback?', - }: Props = $props(); + let props: Props = $props(); + let title = $derived(props.title ?? 'Idee oder Feedback?'); + let defaultCategory = $derived(props.defaultCategory ?? 'feature'); let text = $state(''); - let category = $state(defaultCategory); + let category = $state(props.defaultCategory ?? 'feature'); let isPublic = $state(true); let saving = $state(false); let error = $state(null); @@ -54,7 +50,7 @@ feedbackText: trimmed, category, isPublic, - moduleContext, + moduleContext: props.moduleContext, }); submittedDisplayName = (res as { displayName?: string }).displayName ?? @@ -74,7 +70,7 @@ isPublic = true; error = null; submittedDisplayName = null; - onClose(); + props.onClose(); } function onBackdropKey(e: KeyboardEvent) { @@ -82,9 +78,10 @@ } -{#if open} +{#if props.open} +