till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 22:21:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(mana-core-auth): extract client_id from returnUrl for OIDC login

Browse source 
When redirected from authorization endpoint, the client_id is encoded
in the returnUrl parameter, not directly in query params. This fix
extracts it properly to display the correct application name.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Till-JS 2026-01-30 16:41:39 +01:00
parent eb475aceee
commit 4a66341e08
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
services/mana-core-auth/src/auth/oidc-login.controller.ts
View file

@ -23,12 +23,28 @@ export class OidcLoginController {
*/
@Get('login')
async getLoginPage(@Query() query: Record<string, string>, @Res() res: Response) {
const queryString = new URLSearchParams(query).toString();
const returnUrl = queryString ? `/api/auth/oauth2/authorize?${queryString}` : '/';
// Handle returnUrl parameter (when redirected from authorization endpoint)
let returnUrl = query.returnUrl || '/';
let clientId = query.client_id;
// If no direct client_id but we have returnUrl, extract client_id from it
if (!clientId && query.returnUrl) {
try {
const returnUrlParams = new URLSearchParams(query.returnUrl.split('?')[1] || '');
clientId = returnUrlParams.get('client_id') || undefined;
} catch {
// Ignore parsing errors
}
}
// If no returnUrl was provided, build one from query params (direct OIDC flow)
if (!query.returnUrl && Object.keys(query).length > 0) {
const queryString = new URLSearchParams(query).toString();
returnUrl = `/api/auth/oauth2/authorize?${queryString}`;
}
// Get client name for display
const clientId = query.client_id || 'Unknown';
const clientName = this.getClientDisplayName(clientId);
const clientName = this.getClientDisplayName(clientId || 'Unknown');
const html = `
<!DOCTYPE html>