till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-15 19:59:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(onboarding): move modal outside flex layout containers in 8 apps

Browse source 
The MiniOnboardingModal was nested inside .layout-container (flex) divs
in Chat, Clock, Contacts, Context, ManaDeck, Picture, Presi, and Todo.
This could interfere with fixed positioning, causing the modal to render
incorrectly. Moved all modals to the same nesting level as
SessionExpiredBanner, outside layout containers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-03-25 15:08:34 +01:00
parent 9aa5169f8e
commit 491c71e2b8
8 changed files with 45 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

11
apps/chat/apps/web/src/routes/(protected)/+layout.svelte
View file

@ -216,12 +216,13 @@
</div>
{/if}
</main>
<!-- Onboarding Modal -->
{#if chatOnboarding.shouldShow}
<MiniOnboardingModal store={chatOnboarding} appName="Chat" appEmoji="💬" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if chatOnboarding.shouldShow}
<MiniOnboardingModal store={chatOnboarding} appName="Chat" appEmoji="💬" />
{/if}
<SessionExpiredBanner locale={$locale || 'de'} loginHref="/login" />
</AuthGate>

11
apps/clock/apps/web/src/routes/(app)/+layout.svelte
View file

@ -310,12 +310,13 @@
emptyText="Keine Ergebnisse"
searchingText="Suche..."
/>
<!-- Onboarding Modal -->
{#if clockOnboarding.shouldShow}
<MiniOnboardingModal store={clockOnboarding} appName="Uhr" appEmoji="⏰" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if clockOnboarding.shouldShow}
<MiniOnboardingModal store={clockOnboarding} appName="Uhr" appEmoji="⏰" />
{/if}
<SessionExpiredBanner locale={$locale || 'de'} loginHref="/login" />
</AuthGate>

11
apps/contacts/apps/web/src/routes/(app)/+layout.svelte
View file

@ -384,13 +384,14 @@
{#if newContactModalStore.isOpen}
<NewContactModal onClose={() => newContactModalStore.close()} />
{/if}
<!-- Onboarding Modal -->
{#if contactsOnboarding.shouldShow}
<MiniOnboardingModal store={contactsOnboarding} appName="Kontakte" appEmoji="👥" />
{/if}
</div>
</SplitPaneContainer>
<!-- Onboarding Modal -->
{#if contactsOnboarding.shouldShow}
<MiniOnboardingModal store={contactsOnboarding} appName="Kontakte" appEmoji="👥" />
{/if}
<SessionExpiredBanner locale={$locale || 'de'} loginHref="/login" />
</AuthGate>

10
apps/context/apps/web/src/routes/(app)/+layout.svelte
View file

@ -268,13 +268,13 @@
emptyText="Keine Ergebnisse"
searchingText="Suche..."
/>
<!-- Onboarding Modal -->
{#if contextOnboarding.shouldShow}
<MiniOnboardingModal store={contextOnboarding} appName="Context" appEmoji="📄" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if contextOnboarding.shouldShow}
<MiniOnboardingModal store={contextOnboarding} appName="Context" appEmoji="📄" />
{/if}
<style>
.layout-container {
display: flex;

10
apps/manadeck/apps/web/src/routes/(app)/+layout.svelte
View file

@ -245,10 +245,10 @@
{@render children()}
</div>
</main>
<!-- Onboarding Modal -->
{#if manadeckOnboarding.shouldShow}
<MiniOnboardingModal store={manadeckOnboarding} appName="ManaDeck" appEmoji="🃏" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if manadeckOnboarding.shouldShow}
<MiniOnboardingModal store={manadeckOnboarding} appName="ManaDeck" appEmoji="🃏" />
{/if}
{/if}

11
apps/picture/apps/web/src/routes/app/+layout.svelte
View file

@ -270,12 +270,13 @@
<!-- Keyboard Shortcuts Modal -->
<KeyboardShortcutsModal />
<!-- Onboarding Modal -->
{#if pictureOnboarding.shouldShow}
<MiniOnboardingModal store={pictureOnboarding} appName="Picture" appEmoji="🎨" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if pictureOnboarding.shouldShow}
<MiniOnboardingModal store={pictureOnboarding} appName="Picture" appEmoji="🎨" />
{/if}
<SessionExpiredBanner locale={$locale || 'de'} loginHref="/auth/login" />
</AuthGate>

10
apps/presi/apps/web/src/routes/(app)/+layout.svelte
View file

@ -205,12 +205,12 @@
{@render children()}
</div>
</main>
<!-- Onboarding Modal -->
{#if presiOnboarding.shouldShow}
<MiniOnboardingModal store={presiOnboarding} appName="Presi" appEmoji="📊" />
{/if}
</div>
<!-- Onboarding Modal -->
{#if presiOnboarding.shouldShow}
<MiniOnboardingModal store={presiOnboarding} appName="Presi" appEmoji="📊" />
{/if}
{/if}
<style>

10
apps/todo/apps/web/src/routes/(app)/+layout.svelte
View file

@ -449,12 +449,14 @@
{@render children()}
</div>
</main>
<!-- Onboarding Modal -->
{#if todoOnboarding.shouldShow}
<MiniOnboardingModal store={todoOnboarding} appName="Todo" appEmoji="✅" />
{/if}
</div>
</SplitPaneContainer>
<!-- Onboarding Modal -->
{#if todoOnboarding.shouldShow}
<MiniOnboardingModal store={todoOnboarding} appName="Todo" appEmoji="✅" />
{/if}
<SessionExpiredBanner locale={$locale || 'de'} loginHref="/login" />
</AuthGate>