From 440f6507f1039797d46563ba67c695794ac2d8af Mon Sep 17 00:00:00 2001 From: Till JS Date: Tue, 7 Apr 2026 13:53:13 +0200 Subject: [PATCH] fix: extract types from .svelte files for proper named re-exports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Svelte 5 .svelte modules only expose a default export, so 'export type { X } from "./X.svelte"' fails type-check. Move shared interfaces into adjacent .ts type files. - shared-ui/navigation: SpotlightAction, ContentSearcher, ContentSearch{Result,Group} → types.ts - shared-auth-ui: PasskeyManagerTranslations, TwoFactorSetupTranslations, SessionManagerTranslations → types.ts - mana/web/page-carousel: CarouselPage → new types.ts - mana/web: bump @vitest/* to 4.1.2 (matches lockfile) Co-Authored-By: Claude Opus 4.6 (1M context) --- apps/mana/apps/web/package.json | 6 +- .../page-carousel/PageCarousel.svelte | 11 +-- .../src/lib/components/page-carousel/index.ts | 2 +- .../src/lib/components/page-carousel/types.ts | 9 +++ .../src/components/PasskeyManager.svelte | 28 +------ .../src/components/SessionManager.svelte | 22 +----- .../src/components/TwoFactorSetup.svelte | 28 +------ packages/shared-auth-ui/src/index.ts | 6 +- packages/shared-auth-ui/src/types.ts | 77 +++++++++++++++++++ .../src/navigation/GlobalSpotlight.svelte | 44 ++--------- packages/shared-ui/src/navigation/index.ts | 10 +-- packages/shared-ui/src/navigation/types.ts | 35 +++++++++ 12 files changed, 143 insertions(+), 135 deletions(-) create mode 100644 apps/mana/apps/web/src/lib/components/page-carousel/types.ts diff --git a/apps/mana/apps/web/package.json b/apps/mana/apps/web/package.json index d144cf4d6..8dd14e0a5 100644 --- a/apps/mana/apps/web/package.json +++ b/apps/mana/apps/web/package.json @@ -26,8 +26,8 @@ "@tailwindcss/vite": "^4.1.7", "@types/node": "^22.10.5", "@vite-pwa/sveltekit": "^1.1.0", - "@vitest/coverage-v8": "^4.0.14", - "@vitest/ui": "^4.0.14", + "@vitest/coverage-v8": "^4.1.2", + "@vitest/ui": "^4.1.2", "autoprefixer": "^10.4.20", "fake-indexeddb": "^6.2.5", "postcss": "^8.4.49", @@ -40,7 +40,7 @@ "tslib": "^2.8.1", "typescript": "^5.9.3", "vite": "^6.0.7", - "vitest": "^4.0.14" + "vitest": "^4.1.2" }, "dependencies": { "@calc/shared": "workspace:*", diff --git a/apps/mana/apps/web/src/lib/components/page-carousel/PageCarousel.svelte b/apps/mana/apps/web/src/lib/components/page-carousel/PageCarousel.svelte index d773e9078..4ef971827 100644 --- a/apps/mana/apps/web/src/lib/components/page-carousel/PageCarousel.svelte +++ b/apps/mana/apps/web/src/lib/components/page-carousel/PageCarousel.svelte @@ -6,16 +6,7 @@ import { _ } from 'svelte-i18n'; import { Plus, X, ArrowsOut } from '@mana/shared-icons'; import type { Snippet } from 'svelte'; - - export interface CarouselPage { - id: string; - minimized: boolean; - maximized?: boolean; - widthPx: number; - heightPx?: number; - title: string; - color: string; - } + import type { CarouselPage } from './types'; interface Props { pages: CarouselPage[]; diff --git a/apps/mana/apps/web/src/lib/components/page-carousel/index.ts b/apps/mana/apps/web/src/lib/components/page-carousel/index.ts index a6631bf7d..c8f87f060 100644 --- a/apps/mana/apps/web/src/lib/components/page-carousel/index.ts +++ b/apps/mana/apps/web/src/lib/components/page-carousel/index.ts @@ -1,3 +1,3 @@ export { default as PageShell } from './PageShell.svelte'; export { default as PageCarousel } from './PageCarousel.svelte'; -export type { CarouselPage } from './PageCarousel.svelte'; +export type { CarouselPage } from './types'; diff --git a/apps/mana/apps/web/src/lib/components/page-carousel/types.ts b/apps/mana/apps/web/src/lib/components/page-carousel/types.ts new file mode 100644 index 000000000..a12f979da --- /dev/null +++ b/apps/mana/apps/web/src/lib/components/page-carousel/types.ts @@ -0,0 +1,9 @@ +export interface CarouselPage { + id: string; + minimized: boolean; + maximized?: boolean; + widthPx: number; + heightPx?: number; + title: string; + color: string; +} diff --git a/packages/shared-auth-ui/src/components/PasskeyManager.svelte b/packages/shared-auth-ui/src/components/PasskeyManager.svelte index d97fdf251..c67bf7999 100644 --- a/packages/shared-auth-ui/src/components/PasskeyManager.svelte +++ b/packages/shared-auth-ui/src/components/PasskeyManager.svelte @@ -1,31 +1,5 @@