till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 21:41:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: dev startup — Redis eviction policy, mana-media port crash, Svelte warnings

Browse source 
- Redis: allkeys-lru → noeviction to prevent silent data loss when memory full
- mana-media: --watch → --hot to fix EADDRINUSE crash on Bun HMR reload
- Svelte: build initial values before $state() to avoid state_referenced_locally warnings
  in create-app-onboarding.svelte.ts and shared-llm/store.svelte.ts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-10 18:33:41 +02:00
parent a9956c0009
commit 3e81a6ebef
6 changed files with 25 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

5
packages/shared-llm/src/store.svelte.ts
View file

@ -56,7 +56,8 @@ function persistSettings(settings: LlmSettings): void {
// ─── Reactive state ──────────────────────────────────────────────
let _settings = $state<LlmSettings>(loadSettings());
const initialSettings = loadSettings();
let _settings = $state<LlmSettings>(initialSettings);
// Backends are constructed once per page session. They're stateless
// (or hold their own internal state in the case of BrowserBackend
@ -65,7 +66,7 @@ let _settings = $state<LlmSettings>(loadSettings());
const backends = [new BrowserBackend(), new ManaServerBackend(), new CloudBackend()];
export const llmOrchestrator = new LlmOrchestrator({
settings: _settings,
settings: initialSettings,
backends,
});

32
packages/shared-ui/src/onboarding/create-app-onboarding.svelte.ts
View file

@ -42,21 +42,20 @@ const ONBOARDING_PREFERENCES_KEY = 'onboarding_preferences';
export function createAppOnboardingStore(config: AppOnboardingConfig): AppOnboardingStore {
const { appId, steps, userSettings, onComplete, onSkip } = config;
// State
let currentStep = $state(0);
let preferences = $state<AppOnboardingPreferences>({});
let saving = $state(false);
let completed = $state(false);
// Initialize preferences with default values
// Build initial preferences from step defaults before creating state
const initialPreferences: AppOnboardingPreferences = {};
for (const step of steps) {
if (step.type === 'select' && step.defaultValue !== undefined) {
preferences[step.id] = step.defaultValue;
} else if (step.type === 'toggle' && step.defaultValue !== undefined) {
preferences[step.id] = step.defaultValue;
if ((step.type === 'select' || step.type === 'toggle') && step.defaultValue !== undefined) {
initialPreferences[step.id] = step.defaultValue;
}
}
// State
let currentStep = $state(0);
let preferences = $state<AppOnboardingPreferences>(initialPreferences);
let saving = $state(false);
let completed = $state(false);
// Derived values
const totalSteps = $derived(steps.length);
const isFirstStep = $derived(currentStep === 0);
@ -170,16 +169,7 @@ export function createAppOnboardingStore(config: AppOnboardingConfig): AppOnboar
completed = false;
currentStep = 0;
// Reset preferences to defaults
preferences = {};
for (const step of steps) {
if (step.type === 'select' && step.defaultValue !== undefined) {
preferences[step.id] = step.defaultValue;
} else if (step.type === 'toggle' && step.defaultValue !== undefined) {
preferences[step.id] = step.defaultValue;
}
}
preferences = { ...initialPreferences };
} finally {
saving = false;
}