mirror of
https://github.com/Memo-2023/mana-monorepo.git
synced 2026-05-28 13:57:43 +02:00
fix(build-app): drop --remove-orphans — it nuked 23 cross-app containers
Some checks are pending
CD Mac Mini / Detect Changes (push) Waiting to run
CD Mac Mini / Deploy (push) Blocked by required conditions
CI / Detect Changes (push) Waiting to run
CI / Validate (push) Waiting to run
CI / Build mana-search (push) Blocked by required conditions
CI / Build mana-sync (push) Blocked by required conditions
CI / Build mana-api-gateway (push) Blocked by required conditions
CI / Build mana-crawler (push) Blocked by required conditions
Mirror to Forgejo / Push to Forgejo (push) Waiting to run
Some checks are pending
CD Mac Mini / Detect Changes (push) Waiting to run
CD Mac Mini / Deploy (push) Blocked by required conditions
CI / Detect Changes (push) Waiting to run
CI / Validate (push) Waiting to run
CI / Build mana-search (push) Blocked by required conditions
CI / Build mana-sync (push) Blocked by required conditions
CI / Build mana-api-gateway (push) Blocked by required conditions
CI / Build mana-crawler (push) Blocked by required conditions
Mirror to Forgejo / Push to Forgejo (push) Waiting to run
build-app.sh ran `compose up -d --no-deps --remove-orphans <svc>` in the shared manacore-monorepo project, so every mana-web rebuild deleted all OTHER apps' containers (uload, comicello, moodlit, mana-stats, …) as orphans — a 23-container outage on 2026-05-26. The per-service rm pass already clears this service's own leftovers; --remove-orphans only added the catastrophic cross-app deletion. Removed it; the benign 'Found orphan containers' warning is the accepted trade-off until managarten leaves the shared project. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
7455df03b2
commit
339afa6781
1 changed files with 10 additions and 4 deletions
|
|
@ -227,9 +227,15 @@ build_services() {
|
|||
# (`<hash>_<container_name>`) that compose sometimes creates when
|
||||
# a previous recreate failed mid-cycle. Those aren't tracked by
|
||||
# compose's own state, so `compose rm` misses them.
|
||||
# 3. `up -d --remove-orphans` then creates a clean new container
|
||||
# and silences the "Found orphan containers" warning we kept
|
||||
# seeing for the unrelated mana-game-whopixels leftover.
|
||||
# 3. `up -d` (NO --remove-orphans) creates the clean new container.
|
||||
# --remove-orphans was REMOVED 2026-05-26: this compose runs in the
|
||||
# shared `manacore-monorepo` project (COMPOSE_PROJECT_NAME in
|
||||
# .env.macmini), so --remove-orphans deletes every OTHER app's
|
||||
# containers (uload, comicello, moodlit, mana-stats, …) as
|
||||
# "orphans" — it nuked 23 of them in one rebuild. The per-service
|
||||
# `rm` pass above already clears this service's own leftovers; the
|
||||
# harmless "Found orphan containers" warning is the accepted cost.
|
||||
# See memory project-compose-project-collision.
|
||||
$DOCKER compose "${COMPOSE_ARGS[@]}" rm -fs "${services[@]}" 2>&1 \
|
||||
| grep -v 'No stopped containers' || true
|
||||
for svc in "${services[@]}"; do
|
||||
|
|
@ -252,7 +258,7 @@ build_services() {
|
|||
echo "$orphans" | xargs -r $DOCKER rm -f 2>/dev/null || true
|
||||
fi
|
||||
done
|
||||
$DOCKER compose "${COMPOSE_ARGS[@]}" up -d --no-deps --remove-orphans "${services[@]}" 2>&1
|
||||
$DOCKER compose "${COMPOSE_ARGS[@]}" up -d --no-deps "${services[@]}" 2>&1
|
||||
}
|
||||
|
||||
# --- Main ---
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue