till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 22:01:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(docker): drop more stale shared package COPY lines from sveltekit-base

Browse source 
Three more removed packages had stale COPY entries in the base
Dockerfile, blocking the build the moment is_base_image_stale tried
to rebuild the image:

  - packages/credit-operations  (deleted in NestJS→Hono migration)
  - packages/shared-api-client  (same)
  - packages/shared-splitscreen (separate cleanup)

Same shape as the shared-subscription-types/-ui removal earlier
today (commit a9178ec2f). The deletions go in cleanup commits and
the Dockerfile lines stay behind because nobody runs --base
manually anymore — until is_base_image_stale picks up a packages/
change and tries to rebuild, at which point COPY of a non-existent
path bricks the build.

Removed both the COPY lines AND the corresponding `cd /app/packages/
{credit-operations,shared-api-client} && pnpm build` lines from the
post-install build chain so they can't accidentally re-introduce
the references.

Verified by `grep '^COPY packages/' Dockerfile.sveltekit-base | awk
{print $2} | while read pkg; do [ ! -d $pkg ] && echo MISSING: $pkg;
done` returning empty.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-09 12:25:45 +02:00
parent c8da2267b7
commit 32b0bf9a18
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docker/Dockerfile.sveltekit-base
View file

@ -28,9 +28,9 @@ COPY pnpm-lock.yaml ./
COPY patches/ ./patches/
# Copy ALL shared packages used by SvelteKit web apps
COPY packages/credit-operations ./packages/credit-operations
# packages/credit-operations and packages/shared-api-client were deleted
# during the NestJS-to-Hono migration; their COPY lines are removed.
COPY packages/qr-export ./packages/qr-export
COPY packages/shared-api-client ./packages/shared-api-client
COPY packages/shared-auth ./packages/shared-auth
COPY packages/shared-auth-ui ./packages/shared-auth-ui
COPY packages/shared-branding ./packages/shared-branding
@ -42,7 +42,7 @@ COPY packages/local-store ./packages/local-store
COPY packages/shared-i18n ./packages/shared-i18n
COPY packages/shared-icons ./packages/shared-icons
COPY packages/shared-pwa ./packages/shared-pwa
COPY packages/shared-splitscreen ./packages/shared-splitscreen
# packages/shared-splitscreen was removed; its COPY line is gone too.
COPY packages/shared-stores ./packages/shared-stores
# packages/shared-subscription-types and shared-subscription-ui were
# consolidated into packages/subscriptions (copied below). Their stale
@ -92,8 +92,6 @@ RUN cd packages/shared-vite-config && pnpm build \
&& cd /app/packages/shared-error-tracking && pnpm build \
&& cd /app/packages/shared-pwa && pnpm build \
&& cd /app/packages/shared-tags && pnpm build \
&& cd /app/packages/shared-api-client && pnpm build 2>/dev/null || true \
&& cd /app/packages/credit-operations && pnpm build 2>/dev/null || true \
&& cd /app/packages/spiral-db && pnpm build 2>/dev/null || true
WORKDIR /app