till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 21:21:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

🩹 fix(gifts): add duplicate claim check to first_come type

Browse source 
Users can now only redeem first_come gift codes once, making it
suitable for promo codes that should be unlimited but once per user.
This commit is contained in:
Till-JS 2026-02-14 12:19:43 +01:00
parent acf4512e90
commit 209a474f17
1 changed files with 18 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

29
services/mana-core-auth/src/gifts/services/gift-code.service.ts
View file

@ -319,7 +319,10 @@ export class GiftCodeService {
cancelled: 'This gift code has been cancelled',
refunded: 'This gift code has been refunded',
};
return { success: false, error: statusMessages[giftCode.status] || 'Gift code is not active' };
return {
success: false,
error: statusMessages[giftCode.status] || 'Gift code is not active',
};
}
// 3. Check expiration
@ -345,7 +348,8 @@ export class GiftCodeService {
// 5. Check personalization
if (giftCode.targetEmail || giftCode.targetMatrixId) {
const emailMatch = giftCode.targetEmail && userEmail?.toLowerCase() === giftCode.targetEmail.toLowerCase();
const emailMatch =
giftCode.targetEmail && userEmail?.toLowerCase() === giftCode.targetEmail.toLowerCase();
const matrixMatch = giftCode.targetMatrixId && userMatrixId === giftCode.targetMatrixId;
if (!emailMatch && !matrixMatch) {
@ -368,7 +372,10 @@ export class GiftCodeService {
return { success: false, error: 'Please provide the answer to the riddle' };
}
const isCorrect = await bcrypt.compare(dto.answer.toLowerCase().trim(), giftCode.riddleAnswerHash);
const isCorrect = await bcrypt.compare(
dto.answer.toLowerCase().trim(),
giftCode.riddleAnswerHash
);
if (!isCorrect) {
// Record failed attempt
await tx.insert(giftRedemptions).values({
@ -383,8 +390,13 @@ export class GiftCodeService {
}
}
// 7. Check if user already claimed (for simple/personalized types)
if (giftCode.type === 'simple' || giftCode.type === 'personalized' || giftCode.type === 'riddle') {
// 7. Check if user already claimed (for most types except 'split')
if (
giftCode.type === 'simple' ||
giftCode.type === 'personalized' ||
giftCode.type === 'riddle' ||
giftCode.type === 'first_come'
) {
const [existingClaim] = await tx
.select({ id: giftRedemptions.id })
.from(giftRedemptions)
@ -644,12 +656,7 @@ export class GiftCodeService {
})
.from(giftRedemptions)
.innerJoin(giftCodes, eq(giftRedemptions.giftCodeId, giftCodes.id))
.where(
and(
eq(giftRedemptions.redeemerUserId, userId),
eq(giftRedemptions.status, 'success')
)
)
.where(and(eq(giftRedemptions.redeemerUserId, userId), eq(giftRedemptions.status, 'success')))
.orderBy(desc(giftRedemptions.createdAt))
.limit(50);