till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-14 20:21:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(workbench): replace brittle setTimeout with tick() in scene rename

Browse source 
handleRequestRename focused the scene-header h1 after a hard-coded
120 ms setTimeout. On slower hardware the query fired before the
SceneHeader had re-rendered with the new active scene, focusing the
previous scene's h1. Replacing the timeout with `await tick()` flushes
Svelte's pending DOM updates before the query and removes the magic
number.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-18 15:50:57 +02:00
parent ed801cf725
commit 0a928c1a56
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
apps/mana/apps/web/src/routes/(app)/+page.svelte
View file

@ -413,7 +413,7 @@
bindAgentDialogOpen = true;
}
function handleRequestRename(id: string) {
async function handleRequestRename(id: string) {
// Unified rename path: scroll the carousel to the scene header
// and focus its contenteditable <h1>. Previously opened a modal
// dialog that read from the store while the live header might
@ -423,13 +423,13 @@
if (!scene) return;
if (id !== activeSceneId) workbenchScenesStore.setActiveScene(id);
scrollCarouselToStart();
// Next tick: the header is mounted + the scroll has started;
// querying now lands on the active scene's h1 which
// contenteditable plaintext-only focuses cleanly.
setTimeout(() => {
const h1 = document.querySelector<HTMLElement>('.scene-header .scene-name[contenteditable]');
h1?.focus();
}, 120);
// Await Svelte's flush so the activeScene → SceneHeader re-render
// has landed before we query. Previously we used a 120 ms
// setTimeout, which was brittle on slower hardware and sometimes
// fired before the header was updated, focusing the old scene's h1.
await tick();
const h1 = document.querySelector<HTMLElement>('.scene-header .scene-name[contenteditable]');
h1?.focus();
}
function handleDuplicateScene(id: string) {
workbenchScenesStore.duplicateScene(id);