From 019ad557d49740f512037f3c6d8fb0ac86887488 Mon Sep 17 00:00:00 2001 From: Till JS Date: Tue, 31 Mar 2026 17:15:07 +0200 Subject: [PATCH] fix(shared-pwa): remove favicon.png from default include assets No ManaCore app provides favicon.png (all use favicon.svg). The default caused prerender 404 errors for any app with an /offline page. Co-Authored-By: Claude Opus 4.6 --- apps/inventar/apps/web/svelte.config.js | 7 ------- packages/shared-pwa/src/defaults.ts | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/apps/inventar/apps/web/svelte.config.js b/apps/inventar/apps/web/svelte.config.js index 12e2985cd..a7a917e4c 100644 --- a/apps/inventar/apps/web/svelte.config.js +++ b/apps/inventar/apps/web/svelte.config.js @@ -8,13 +8,6 @@ const config = { adapter: adapter({ out: 'build', }), - prerender: { - handleHttpError: ({ path, message }) => { - // Ignore missing PNG assets (app only provides favicon.svg) - if (path.endsWith('.png')) return; - throw new Error(message); - }, - }, }, }; diff --git a/packages/shared-pwa/src/defaults.ts b/packages/shared-pwa/src/defaults.ts index 7d08e6d38..80940dfa0 100644 --- a/packages/shared-pwa/src/defaults.ts +++ b/packages/shared-pwa/src/defaults.ts @@ -17,7 +17,7 @@ export const DEFAULT_CATEGORIES = ['productivity', 'utilities']; /** * Default assets to include in PWA */ -export const DEFAULT_INCLUDE_ASSETS = ['favicon.png', 'favicon.svg']; +export const DEFAULT_INCLUDE_ASSETS = ['favicon.svg']; /** * Default glob patterns for precaching