till/managarten
1
0
Fork 0
mirror of https://github.com/Memo-2023/mana-monorepo.git synced 2026-05-18 18:01:23 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(type-check): clear the last five failures — monorepo type-check is now 76/76 green

Browse source 
After the mobile-app deletion unblocked \`@context/mobile\`, five more
pre-existing failures surfaced across shared packages and two services.
All were silent-masked by the postinstall \`|| true\` for months.

- **shared-ai**: \`planner/loop.ts\` imported \`ToolSchema\` from
  \`../tools/function-schema\`, which only imports (not re-exports) the
  type. Fixed to import from the source (\`../tools/schemas\`).
- **shared-logger**: \`typeof window !== 'undefined'\` blows up under
  tsconfigs that don't include the DOM lib (e.g. uload-server's
  \`bun-types\`-only config), because shared-logger is consumed via
  source import. Replaced with a \`globalThis\`-indirected check that
  compiles under any lib configuration.
- **shared-hono**: \`credits.ts\` returned \`res.json()\` directly as
  \`Promise<T | null>\`. Modern \`@types/node\` / undici types return
  \`unknown\` strictly — cast to \`T\` at the boundary so the generic
  contract is explicit.
- **uload-server**: \`routes/analytics.ts\` + \`routes/email.ts\` still
  imported \`AuthUser\` from a \`middleware/jwt-auth\` module that was
  deleted during the migration to \`@mana/shared-hono\`. Replaced with
  \`AuthVariables\` from shared-hono, which matches the actual context
  shape set by \`authMiddleware()\`.
- **manavoxel/web**: \`guestSeed\` collection entries were wrapped in
  arrow functions, but \`local-store\` expects \`T[]\` directly and
  iterates \`seed.length\` — which on a function is 0. The "guest
  seed" was silently dead; eager-evaluating \`generateGuestWorld()\`
  once and sharing the result fixes both the type and the runtime.

Verified: \`pnpm run type-check\` from the repo root now exits 0 —
76/76 tasks successful, no failures. First fully green state since
well before the postinstall \`|| true\` was introduced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Till JS 2026-04-20 15:53:07 +02:00
parent a44e3df1d0
commit 0077752456
7 changed files with 22 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
apps/uload/apps/server/src/routes/analytics.ts
View file

@ -1,9 +1,9 @@
import { Hono } from 'hono';
import type { AuthVariables } from '@mana/shared-hono';
import type { AnalyticsService } from '../services/analytics';
import type { AuthUser } from '../middleware/jwt-auth';
export function createAnalyticsRoutes(analyticsService: AnalyticsService) {
return new Hono<{ Variables: { user: AuthUser } }>()
return new Hono<{ Variables: AuthVariables }>()
.get('/:linkId', async (c) => {
const linkId = c.req.param('linkId');
const stats = await analyticsService.getClickStats(linkId);

4
apps/uload/apps/server/src/routes/email.ts
View file

@ -1,8 +1,8 @@
import { Hono } from 'hono';
import type { AuthUser } from '../middleware/jwt-auth';
import type { AuthVariables } from '@mana/shared-hono';
export function createEmailRoutes() {
return new Hono<{ Variables: { user: AuthUser } }>().post('/send-invitation', async (c) => {
return new Hono<{ Variables: AuthVariables }>().post('/send-invitation', async (c) => {
// TODO: Implement with Resend
return c.json({ error: 'Email not configured yet' }, 501);
});