Phase 3 follow-up: type-check + tests grün, ts-fsrs v5 API

- tsconfig.base.json: allowImportingTsExtensions + noEmit (.ts-Imports
  in dev, kein tsc-Output, vitest/bun/vite handhaben Build)
- ts-fsrs v5.3.2 API-Updates:
  - scheduler.next(card, now, grade) statt repeat(card, now)[rating].card
  - Grade-Type für RATING_TO_FSRS (excluded Manual)
  - learning_steps-Feld auf Review (Schema, Drizzle-Column, Adapter,
    DTO-Konverter, Tests)
- apps/web: extends .svelte-kit/tsconfig.json (SvelteKit-Empfehlung),
  test-Script mit --passWithNoTests
- apps/api: dropped types: ['bun-types'] (stale)
- pnpm-lock.yaml committed

Status:
- pnpm run type-check ✅ 4/4 packages grün (api, domain, web mit
  svelte-check 0 errors)
- pnpm run test ✅ 46 Tests grün (cards-domain: 27, apps/api: 19,
  apps/web: --passWithNoTests)
- pnpm install ✅ 136 packages, 8s

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

apps/api/src/db/schema/reviews.ts

@@ -30,6 +30,7 @@ export const reviews = cardsSchema.table(
 		difficulty: real('difficulty').notNull(),
 		elapsedDays: real('elapsed_days').notNull().default(0),
 		scheduledDays: real('scheduled_days').notNull().default(0),
+		learningSteps: integer('learning_steps').notNull().default(0),
 		reps: integer('reps').notNull().default(0),
 		lapses: integer('lapses').notNull().default(0),
 		state: text('state', { enum: ['new', 'learning', 'review', 'relearning'] })

apps/api/src/routes/cards.ts

@@ -71,6 +71,7 @@ export function cardsRouter(deps: CardsDeps = {}): Hono<{ Variables: AuthVars }>
 					difficulty: r.difficulty,
 					elapsedDays: r.elapsed_days,
 					scheduledDays: r.scheduled_days,
+					learningSteps: r.learning_steps,
 					reps: r.reps,
 					lapses: r.lapses,
 					state: r.state,

apps/api/src/routes/reviews.ts

@@ -122,6 +122,7 @@ export function reviewsRouter(deps: ReviewsDeps = {}): Hono<{ Variables: AuthVar
 				difficulty: next.difficulty,
 				elapsedDays: next.elapsed_days,
 				scheduledDays: next.scheduled_days,
+				learningSteps: next.learning_steps,
 				reps: next.reps,
 				lapses: next.lapses,
 				state: next.state,
@@ -152,6 +153,7 @@ function toReviewDto(row: typeof reviews.$inferSelect): DomainReview {
 		difficulty: row.difficulty,
 		elapsed_days: row.elapsedDays,
 		scheduled_days: row.scheduledDays,
+		learning_steps: row.learningSteps,
 		reps: row.reps,
 		lapses: row.lapses,
 		state: row.state,

apps/api/tsconfig.json

@@ -2,8 +2,6 @@
 	"extends": "../../tsconfig.base.json",
 	"compilerOptions": {
 		"outDir": "./dist",
-		"rootDir": "./src",
-		"types": ["bun-types"],
 		"baseUrl": ".",
 		"paths": {
 			"@/*": ["src/*"]

apps/web/package.json

@@ -10,7 +10,7 @@
 		"preview": "vite preview",
 		"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
 		"type-check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
-		"test": "vitest run",
+		"test": "vitest run --passWithNoTests",
 		"lint": "echo 'lint configured later (eslint flat-config)'",
 		"clean": "rm -rf .svelte-kit build .turbo"
 	},

apps/web/tsconfig.json

@@ -1,21 +1,12 @@
 {
-	"extends": "../../tsconfig.base.json",
+	"extends": "./.svelte-kit/tsconfig.json",
 	"compilerOptions": {
+		"strict": true,
 		"allowJs": true,
 		"checkJs": true,
 		"sourceMap": true,
-		"strict": true,
+		"moduleResolution": "bundler",
-		"moduleResolution": "bundler"
+		"allowImportingTsExtensions": true,
-	},
+		"noEmit": true
-	"include": [
+	}
-		".svelte-kit/ambient.d.ts",
-		".svelte-kit/non-ambient.d.ts",
-		".svelte-kit/types/**/$types.d.ts",
-		"vite.config.ts",
-		"src/**/*.js",
-		"src/**/*.ts",
-		"src/**/*.svelte",
-		"tests/**/*"
-	],
-	"exclude": ["node_modules", ".svelte-kit/output", "build"]
 }

packages/cards-domain/src/fsrs.ts

@@ -8,20 +8,18 @@
 
 import {
 	createEmptyCard,
-	default_w,
 	FSRS,
-	generatorParameters,
 	Rating as FsrsRating,
 	State as FsrsState,
 	type Card as FsrsCard,
-	type FSRSParameters,
+	type Grade,
 } from 'ts-fsrs';
 
 import type { Rating, Review, ReviewState } from './schemas/review.ts';
 import type { FsrsSettings } from './schemas/fsrs-settings.ts';
 
-/** Public Rating ↔ ts-fsrs Rating mapping. */
+/** Public Rating ↔ ts-fsrs Grade (Manual ist explizit ausgeschlossen). */
-const RATING_TO_FSRS: Record<Rating, FsrsRating> = {
+const RATING_TO_FSRS: Record<Rating, Grade> = {
 	again: FsrsRating.Again,
 	hard: FsrsRating.Hard,
 	good: FsrsRating.Good,
@@ -45,13 +43,14 @@ const STATE_TO_FSRS: Record<ReviewState, FsrsState> = {
 
 /** Baut einen FSRS-Scheduler aus per-Deck-Settings + globalen Defaults. */
 export function buildScheduler(settings: FsrsSettings = {}): FSRS {
-	const params: FSRSParameters = generatorParameters({
+	return new FSRS({
+		...(settings.request_retention !== undefined && {
 			request_retention: settings.request_retention,
-		maximum_interval: settings.maximum_interval,
+		}),
-		w: settings.w ?? default_w,
+		...(settings.maximum_interval !== undefined && { maximum_interval: settings.maximum_interval }),
-		enable_fuzz: settings.enable_fuzz ?? true,
+		...(settings.w !== undefined && { w: settings.w }),
+		...(settings.enable_fuzz !== undefined && { enable_fuzz: settings.enable_fuzz }),
 	});
-	return new FSRS(params);
 }
 
 /** Initialer Review-State für eine neue Karte (sub_index). */
@@ -72,6 +71,7 @@ export function newReview(args: {
 		difficulty: fc.difficulty,
 		elapsed_days: fc.elapsed_days,
 		scheduled_days: fc.scheduled_days,
+		learning_steps: fc.learning_steps,
 		reps: fc.reps,
 		lapses: fc.lapses,
 		state: STATE_FROM_FSRS[fc.state],
@@ -88,10 +88,8 @@ export function gradeReview(
 ): Review {
 	const reviewedAt = now ?? new Date();
 	const scheduler = buildScheduler(settings);
-	const fc = toFsrsCard(current);
+	const result = scheduler.next(toFsrsCard(current), reviewedAt, RATING_TO_FSRS[rating]);
-	const log = scheduler.repeat(fc, reviewedAt);
+	return fromFsrsCard(current, result.card);
-	const next = log[RATING_TO_FSRS[rating]].card;
-	return fromFsrsCard(current, next);
 }
 
 /** Konvertiert unseren Review-Datensatz in eine ts-fsrs Card. */
@@ -102,6 +100,7 @@ export function toFsrsCard(r: Review): FsrsCard {
 		difficulty: r.difficulty,
 		elapsed_days: r.elapsed_days,
 		scheduled_days: r.scheduled_days,
+		learning_steps: r.learning_steps,
 		reps: r.reps,
 		lapses: r.lapses,
 		state: STATE_TO_FSRS[r.state],
@@ -118,6 +117,7 @@ export function fromFsrsCard(prev: Review, fc: FsrsCard): Review {
 		difficulty: fc.difficulty,
 		elapsed_days: fc.elapsed_days,
 		scheduled_days: fc.scheduled_days,
+		learning_steps: fc.learning_steps,
 		reps: fc.reps,
 		lapses: fc.lapses,
 		state: STATE_FROM_FSRS[fc.state],

packages/cards-domain/src/schemas/review.ts

@@ -17,6 +17,7 @@ export const ReviewSchema = z
 		difficulty: z.number().min(0).max(10),
 		elapsed_days: z.number().nonnegative().default(0),
 		scheduled_days: z.number().nonnegative().default(0),
+		learning_steps: z.number().int().nonnegative().default(0),
 		reps: z.number().int().nonnegative().default(0),
 		lapses: z.number().int().nonnegative().default(0),
 		state: ReviewStateSchema.default('new'),

packages/cards-domain/tsconfig.json

@@ -2,7 +2,6 @@
 	"extends": "../../tsconfig.base.json",
 	"compilerOptions": {
 		"outDir": "./dist",
-		"rootDir": "./src",
 		"declaration": true,
 		"declarationMap": true,
 		"sourceMap": true

tsconfig.base.json

@@ -10,6 +10,8 @@
 		"forceConsistentCasingInFileNames": true,
 		"resolveJsonModule": true,
 		"isolatedModules": true,
-		"verbatimModuleSyntax": false
+		"verbatimModuleSyntax": false,
+		"allowImportingTsExtensions": true,
+		"noEmit": true
 	}
 }