Bringt cards-native auf 0 SwiftLint-Violations bei 75 Files. Build-Status
unverändert grün (xcodebuild iOS Debug).
.swiftlint.yml
- identifier_name excludes erweitert um math/index-Konventionen
(i, j, n, m, x, y, w, h, r, g, b, a, c, d, s, f, p, q, t, l) —
in algorithmischem Code klarer als verbose
- opening_brace disabled — kollidiert mit SwiftFormats
wrapMultilineStatementBraces (SwiftFormat ist im Pre-Commit-Hook
und gewinnt)
Code-Modernisierungen (real, nicht nur Annotations)
- Cloze.swift: regex-Tuple bekommt `swiftlint:disable large_tuple`-
Region — Regex-Output-Type ist Builder-bedingt nicht reduzierbar
- Media.swift: `data(using: .utf8)` → `Data(s.utf8)` (non-failable),
`String(data:as:)` → `String(bytes:encoding:)`
- CardsTheme.swift: HSL-Wert-Typ statt anonymes 3-Tupel —
konkretere Call-Sites, kein `large_tuple`-Warning mehr
- MediaCache.swift: `CacheEntry`-Struct statt 3-Tupel im Prune-Pfad
- GradeQueue / MediaCache / StudySession / MarketplaceStore: OSLog-
Interpolations auf lokale Variablen ziehen — fixt Swift-6-Strict-
Concurrency-Fail bei Actor-isolated-Property-Zugriff aus
@Sendable-Autoclosure
- DeckMutations.swift, MarketplaceModeration.swift: verschachtelte
VersionInfo-Sub-Types auf Top-Level (`PullUpdateVersion`,
`OwnedMarketplaceVersion`) — fixt `nesting`-Warning
- Tests/UnitTests/*.swift: alle `""".data(using: .utf8)!` migriert auf
`Data("""…""".utf8)`; force-cast `as!` in MutationEncodingTests
durch guard-let + throw ersetzt
Pragmatische Disables (mit Doc-Comment-Begründung)
- DeckEditorView / MarketplacePublishView / DeckDetailView /
PublicDeckView / DeckListView / CardEditorView / CardsAPI:
`swiftlint:disable type_body_length` (+ teilweise file_length)
als Region-Disable mit `enable` nach dem Struct. Begründung im
Doc-Comment: Multi-State-Maschinen mit shared Toolbar + Sheets;
Aufspalten würde nur @Binding-Plumbing produzieren
Auto-Format-Aufräumung
- Redundante `Sendable`-Conformance entfernt (Swift 6 leitet das
bei Wert-Typen mit Sendable-Mitgliedern automatisch ab)
- EnvironmentValues nutzt jetzt @Entry-Macro statt manueller
EnvironmentKey-Boilerplate
- Brace-Reformatting + Import-Sortierung auf allen 75 Files
Ergebnis: 80 Warnings + 3 Errors → 0 / 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
115 lines
2.9 KiB
Swift
115 lines
2.9 KiB
Swift
import Foundation
|
|
|
|
/// Rating-Werte für `POST /reviews/:cardId/:subIndex/grade`.
|
|
/// Aus `cards/packages/cards-domain/src/schemas/review.ts:RatingSchema`.
|
|
enum Rating: String, Codable, CaseIterable {
|
|
case again
|
|
case hard
|
|
case good
|
|
case easy
|
|
|
|
/// Anzeige-Label auf dem Rating-Button.
|
|
var label: String {
|
|
switch self {
|
|
case .again: "Nochmal"
|
|
case .hard: "Schwer"
|
|
case .good: "Gut"
|
|
case .easy: "Leicht"
|
|
}
|
|
}
|
|
|
|
/// Kurz-Symbol für minimalistische UI.
|
|
var shortcut: String {
|
|
switch self {
|
|
case .again: "1"
|
|
case .hard: "2"
|
|
case .good: "3"
|
|
case .easy: "4"
|
|
}
|
|
}
|
|
}
|
|
|
|
/// FSRS-Review-State. Aus `ReviewStateSchema`.
|
|
enum ReviewState: String, Codable {
|
|
case new
|
|
case learning
|
|
case review
|
|
case relearning
|
|
}
|
|
|
|
/// Review-DTO. Wire-Format aus `cards/apps/api/src/routes/reviews.ts:toReviewDto`.
|
|
struct Review: Codable, Hashable {
|
|
let cardId: String
|
|
let subIndex: Int
|
|
let userId: String
|
|
let due: Date
|
|
let stability: Double
|
|
let difficulty: Double
|
|
let elapsedDays: Double
|
|
let scheduledDays: Double
|
|
let learningSteps: Int
|
|
let reps: Int
|
|
let lapses: Int
|
|
let state: ReviewState
|
|
let lastReview: Date?
|
|
|
|
enum CodingKeys: String, CodingKey {
|
|
case cardId = "card_id"
|
|
case subIndex = "sub_index"
|
|
case userId = "user_id"
|
|
case due
|
|
case stability
|
|
case difficulty
|
|
case elapsedDays = "elapsed_days"
|
|
case scheduledDays = "scheduled_days"
|
|
case learningSteps = "learning_steps"
|
|
case reps
|
|
case lapses
|
|
case state
|
|
case lastReview = "last_review"
|
|
}
|
|
}
|
|
|
|
/// Eintrag aus `/reviews/due?deck_id=X` — Review + zugehörige Card.
|
|
struct DueReview: Codable, Hashable, Identifiable {
|
|
let review: Review
|
|
let card: ReviewCard
|
|
|
|
var id: String {
|
|
"\(review.cardId)-\(review.subIndex)"
|
|
}
|
|
|
|
init(from decoder: Decoder) throws {
|
|
let container = try decoder.container(keyedBy: CodingKeys.self)
|
|
// Flat-Decoding: Review-Felder + card-Objekt im selben JSON-Objekt
|
|
review = try Review(from: decoder)
|
|
card = try container.decode(ReviewCard.self, forKey: .card)
|
|
}
|
|
|
|
func encode(to encoder: Encoder) throws {
|
|
try review.encode(to: encoder)
|
|
var container = encoder.container(keyedBy: CodingKeys.self)
|
|
try container.encode(card, forKey: .card)
|
|
}
|
|
|
|
enum CodingKeys: String, CodingKey {
|
|
case card
|
|
}
|
|
}
|
|
|
|
/// Wrapper-Response von `GET /api/v1/reviews/due?deck_id=X`.
|
|
struct DueReviewsListResponse: Decodable {
|
|
let reviews: [DueReview]
|
|
let total: Int
|
|
}
|
|
|
|
/// Body für `POST /reviews/:cardId/:subIndex/grade`.
|
|
struct GradeReviewBody: Encodable {
|
|
let rating: Rating
|
|
let reviewedAt: Date
|
|
|
|
enum CodingKeys: String, CodingKey {
|
|
case rating
|
|
case reviewedAt = "reviewed_at"
|
|
}
|
|
}
|