aece169360
Bringt cards-native auf 0 SwiftLint-Violations bei 75 Files. Build-Status
unverändert grün (xcodebuild iOS Debug).
.swiftlint.yml
- identifier_name excludes erweitert um math/index-Konventionen
(i, j, n, m, x, y, w, h, r, g, b, a, c, d, s, f, p, q, t, l) —
in algorithmischem Code klarer als verbose
- opening_brace disabled — kollidiert mit SwiftFormats
wrapMultilineStatementBraces (SwiftFormat ist im Pre-Commit-Hook
und gewinnt)
Code-Modernisierungen (real, nicht nur Annotations)
- Cloze.swift: regex-Tuple bekommt `swiftlint:disable large_tuple`-
Region — Regex-Output-Type ist Builder-bedingt nicht reduzierbar
- Media.swift: `data(using: .utf8)` → `Data(s.utf8)` (non-failable),
`String(data:as:)` → `String(bytes:encoding:)`
- CardsTheme.swift: HSL-Wert-Typ statt anonymes 3-Tupel —
konkretere Call-Sites, kein `large_tuple`-Warning mehr
- MediaCache.swift: `CacheEntry`-Struct statt 3-Tupel im Prune-Pfad
- GradeQueue / MediaCache / StudySession / MarketplaceStore: OSLog-
Interpolations auf lokale Variablen ziehen — fixt Swift-6-Strict-
Concurrency-Fail bei Actor-isolated-Property-Zugriff aus
@Sendable-Autoclosure
- DeckMutations.swift, MarketplaceModeration.swift: verschachtelte
VersionInfo-Sub-Types auf Top-Level (`PullUpdateVersion`,
`OwnedMarketplaceVersion`) — fixt `nesting`-Warning
- Tests/UnitTests/*.swift: alle `""".data(using: .utf8)!` migriert auf
`Data("""…""".utf8)`; force-cast `as!` in MutationEncodingTests
durch guard-let + throw ersetzt
Pragmatische Disables (mit Doc-Comment-Begründung)
- DeckEditorView / MarketplacePublishView / DeckDetailView /
PublicDeckView / DeckListView / CardEditorView / CardsAPI:
`swiftlint:disable type_body_length` (+ teilweise file_length)
als Region-Disable mit `enable` nach dem Struct. Begründung im
Doc-Comment: Multi-State-Maschinen mit shared Toolbar + Sheets;
Aufspalten würde nur @Binding-Plumbing produzieren
Auto-Format-Aufräumung
- Redundante `Sendable`-Conformance entfernt (Swift 6 leitet das
bei Wert-Typen mit Sendable-Mitgliedern automatisch ab)
- EnvironmentValues nutzt jetzt @Entry-Macro statt manueller
EnvironmentKey-Boilerplate
- Brace-Reformatting + Import-Sortierung auf allen 75 Files
Ergebnis: 80 Warnings + 3 Errors → 0 / 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
107 lines
3.6 KiB
Swift
107 lines
3.6 KiB
Swift
import Foundation
|
|
import Testing
|
|
@testable import CardsNative
|
|
|
|
@Suite("Mutation Body Encoding")
|
|
struct MutationEncodingTests {
|
|
private func encode(_ value: some Encodable) throws -> [String: Any] {
|
|
let data = try JSONEncoder().encode(value)
|
|
guard let dict = try JSONSerialization.jsonObject(with: data) as? [String: Any] else {
|
|
throw EncodeError.notADictionary
|
|
}
|
|
return dict
|
|
}
|
|
|
|
private enum EncodeError: Error {
|
|
case notADictionary
|
|
}
|
|
|
|
@Test("DeckCreateBody nutzt snake_case und lässt nil weg")
|
|
func deckCreateBody() throws {
|
|
let body = DeckCreateBody(
|
|
name: "Spanisch",
|
|
description: nil,
|
|
color: "#10803D",
|
|
category: .language,
|
|
visibility: .private
|
|
)
|
|
let json = try encode(body)
|
|
#expect(json["name"] as? String == "Spanisch")
|
|
#expect(json["color"] as? String == "#10803D")
|
|
#expect(json["category"] as? String == "language")
|
|
#expect(json["visibility"] as? String == "private")
|
|
// description war nil — sollte nicht im JSON sein
|
|
#expect(json["description"] == nil)
|
|
}
|
|
|
|
@Test("DeckUpdateBody kann archived: true setzen")
|
|
func deckUpdateBodyArchived() throws {
|
|
let body = DeckUpdateBody(archived: true)
|
|
let json = try encode(body)
|
|
#expect(json["archived"] as? Bool == true)
|
|
#expect(json["name"] == nil)
|
|
}
|
|
|
|
@Test("CardCreateBody für basic-Type")
|
|
func cardCreateBodyBasic() throws {
|
|
let body = CardCreateBody(
|
|
deckId: "deck_1",
|
|
type: .basic,
|
|
fields: CardFieldsBuilder.basic(front: "Hallo", back: "Hello"),
|
|
mediaRefs: nil
|
|
)
|
|
let json = try encode(body)
|
|
#expect(json["deck_id"] as? String == "deck_1")
|
|
#expect(json["type"] as? String == "basic")
|
|
let fields = json["fields"] as? [String: String]
|
|
#expect(fields?["front"] == "Hallo")
|
|
#expect(fields?["back"] == "Hello")
|
|
#expect(json["media_refs"] == nil)
|
|
}
|
|
|
|
@Test("CardCreateBody für basic-reverse Type-Name")
|
|
func cardCreateBodyBasicReverse() throws {
|
|
let body = CardCreateBody(
|
|
deckId: "d",
|
|
type: .basicReverse,
|
|
fields: CardFieldsBuilder.basic(front: "a", back: "b"),
|
|
mediaRefs: nil
|
|
)
|
|
let json = try encode(body)
|
|
#expect(json["type"] as? String == "basic-reverse")
|
|
}
|
|
|
|
@Test("CardCreateBody für cloze")
|
|
func cardCreateBodyCloze() throws {
|
|
let body = CardCreateBody(
|
|
deckId: "d",
|
|
type: .cloze,
|
|
fields: CardFieldsBuilder.cloze(text: "Die {{c1::Sonne}} scheint."),
|
|
mediaRefs: nil
|
|
)
|
|
let json = try encode(body)
|
|
#expect(json["type"] as? String == "cloze")
|
|
let fields = json["fields"] as? [String: String]
|
|
#expect(fields?["text"] == "Die {{c1::Sonne}} scheint.")
|
|
}
|
|
|
|
@Test("CardCreateBody multiple-choice Type-Name")
|
|
func cardCreateBodyMultipleChoice() throws {
|
|
let body = CardCreateBody(
|
|
deckId: "d",
|
|
type: .multipleChoice,
|
|
fields: CardFieldsBuilder.multipleChoice(front: "Q", answer: "A"),
|
|
mediaRefs: nil
|
|
)
|
|
let json = try encode(body)
|
|
#expect(json["type"] as? String == "multiple-choice")
|
|
}
|
|
|
|
@Test("CardUpdateBody nur mit fields")
|
|
func cardUpdateBodyFieldsOnly() throws {
|
|
let body = CardUpdateBody(fields: ["front": "neu"], mediaRefs: nil)
|
|
let json = try encode(body)
|
|
#expect((json["fields"] as? [String: String])?["front"] == "neu")
|
|
#expect(json["media_refs"] == nil)
|
|
}
|
|
}
|