aece169360
Bringt cards-native auf 0 SwiftLint-Violations bei 75 Files. Build-Status
unverändert grün (xcodebuild iOS Debug).
.swiftlint.yml
- identifier_name excludes erweitert um math/index-Konventionen
(i, j, n, m, x, y, w, h, r, g, b, a, c, d, s, f, p, q, t, l) —
in algorithmischem Code klarer als verbose
- opening_brace disabled — kollidiert mit SwiftFormats
wrapMultilineStatementBraces (SwiftFormat ist im Pre-Commit-Hook
und gewinnt)
Code-Modernisierungen (real, nicht nur Annotations)
- Cloze.swift: regex-Tuple bekommt `swiftlint:disable large_tuple`-
Region — Regex-Output-Type ist Builder-bedingt nicht reduzierbar
- Media.swift: `data(using: .utf8)` → `Data(s.utf8)` (non-failable),
`String(data:as:)` → `String(bytes:encoding:)`
- CardsTheme.swift: HSL-Wert-Typ statt anonymes 3-Tupel —
konkretere Call-Sites, kein `large_tuple`-Warning mehr
- MediaCache.swift: `CacheEntry`-Struct statt 3-Tupel im Prune-Pfad
- GradeQueue / MediaCache / StudySession / MarketplaceStore: OSLog-
Interpolations auf lokale Variablen ziehen — fixt Swift-6-Strict-
Concurrency-Fail bei Actor-isolated-Property-Zugriff aus
@Sendable-Autoclosure
- DeckMutations.swift, MarketplaceModeration.swift: verschachtelte
VersionInfo-Sub-Types auf Top-Level (`PullUpdateVersion`,
`OwnedMarketplaceVersion`) — fixt `nesting`-Warning
- Tests/UnitTests/*.swift: alle `""".data(using: .utf8)!` migriert auf
`Data("""…""".utf8)`; force-cast `as!` in MutationEncodingTests
durch guard-let + throw ersetzt
Pragmatische Disables (mit Doc-Comment-Begründung)
- DeckEditorView / MarketplacePublishView / DeckDetailView /
PublicDeckView / DeckListView / CardEditorView / CardsAPI:
`swiftlint:disable type_body_length` (+ teilweise file_length)
als Region-Disable mit `enable` nach dem Struct. Begründung im
Doc-Comment: Multi-State-Maschinen mit shared Toolbar + Sheets;
Aufspalten würde nur @Binding-Plumbing produzieren
Auto-Format-Aufräumung
- Redundante `Sendable`-Conformance entfernt (Swift 6 leitet das
bei Wert-Typen mit Sendable-Mitgliedern automatisch ab)
- EnvironmentValues nutzt jetzt @Entry-Macro statt manueller
EnvironmentKey-Boilerplate
- Brace-Reformatting + Import-Sortierung auf allen 75 Files
Ergebnis: 80 Warnings + 3 Errors → 0 / 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
105 lines
3.6 KiB
Swift
105 lines
3.6 KiB
Swift
import Foundation
|
|
import Testing
|
|
@testable import CardsNative
|
|
|
|
@Suite("Deck-JSON-Decoding")
|
|
struct DeckDecodingTests {
|
|
@Test("Wire-Format aus toDeckDto decodet sauber")
|
|
func decodesDeckFromWireFormat() throws {
|
|
let json = Data("""
|
|
{
|
|
"id": "01ARZ3NDEKTSV4RRFFQ69G5FAV",
|
|
"user_id": "user_123",
|
|
"name": "Spanisch A1",
|
|
"description": "Grundwortschatz",
|
|
"color": "#10803D",
|
|
"category": "language",
|
|
"visibility": "private",
|
|
"fsrs_settings": {"request_retention": 0.9, "maximum_interval": 365},
|
|
"content_hash": "abc123",
|
|
"forked_from_marketplace_deck_id": null,
|
|
"forked_from_marketplace_version_id": null,
|
|
"archived_at": null,
|
|
"created_at": "2026-05-12T10:30:00.123Z",
|
|
"updated_at": "2026-05-12T15:45:00.456Z"
|
|
}
|
|
""".utf8)
|
|
|
|
let decoder = JSONDecoder()
|
|
decoder.dateDecodingStrategy = .iso8601withFractional
|
|
let deck = try decoder.decode(Deck.self, from: json)
|
|
|
|
#expect(deck.id == "01ARZ3NDEKTSV4RRFFQ69G5FAV")
|
|
#expect(deck.name == "Spanisch A1")
|
|
#expect(deck.description == "Grundwortschatz")
|
|
#expect(deck.color == "#10803D")
|
|
#expect(deck.category == .language)
|
|
#expect(deck.visibility == .private)
|
|
#expect(deck.isFromMarketplace == false)
|
|
#expect(deck.archivedAt == nil)
|
|
}
|
|
|
|
@Test("Marketplace-Forks werden erkannt")
|
|
func recognizesMarketplaceFork() throws {
|
|
let json = Data("""
|
|
{
|
|
"id": "deck_456",
|
|
"user_id": "user_123",
|
|
"name": "Geografie",
|
|
"description": null,
|
|
"color": null,
|
|
"category": null,
|
|
"visibility": "private",
|
|
"fsrs_settings": {},
|
|
"content_hash": null,
|
|
"forked_from_marketplace_deck_id": "mp_deck_789",
|
|
"forked_from_marketplace_version_id": "mp_ver_1",
|
|
"archived_at": null,
|
|
"created_at": "2026-05-01T00:00:00.000Z",
|
|
"updated_at": "2026-05-01T00:00:00.000Z"
|
|
}
|
|
""".utf8)
|
|
|
|
let decoder = JSONDecoder()
|
|
decoder.dateDecodingStrategy = .iso8601withFractional
|
|
let deck = try decoder.decode(Deck.self, from: json)
|
|
|
|
#expect(deck.isFromMarketplace == true)
|
|
#expect(deck.forkedFromMarketplaceDeckId == "mp_deck_789")
|
|
#expect(deck.category == nil)
|
|
}
|
|
|
|
@Test("DeckListResponse-Wrapper")
|
|
func decodesListResponse() throws {
|
|
let json = Data("""
|
|
{
|
|
"decks": [
|
|
{
|
|
"id": "d1",
|
|
"user_id": "u1",
|
|
"name": "Deck 1",
|
|
"description": null,
|
|
"color": null,
|
|
"category": null,
|
|
"visibility": "private",
|
|
"fsrs_settings": {},
|
|
"content_hash": null,
|
|
"forked_from_marketplace_deck_id": null,
|
|
"forked_from_marketplace_version_id": null,
|
|
"archived_at": null,
|
|
"created_at": "2026-01-01T00:00:00.000Z",
|
|
"updated_at": "2026-01-01T00:00:00.000Z"
|
|
}
|
|
],
|
|
"total": 1
|
|
}
|
|
""".utf8)
|
|
|
|
let decoder = JSONDecoder()
|
|
decoder.dateDecodingStrategy = .iso8601withFractional
|
|
let response = try decoder.decode(DeckListResponse.self, from: json)
|
|
|
|
#expect(response.total == 1)
|
|
#expect(response.decks.first?.name == "Deck 1")
|
|
}
|
|
}
|