chore(lint): SwiftLint-Config + 0-Warnings-Pass + Swift-6-Concurrency-Fixes
Bringt cards-native auf 0 SwiftLint-Violations bei 75 Files. Build-Status
unverändert grün (xcodebuild iOS Debug).
.swiftlint.yml
- identifier_name excludes erweitert um math/index-Konventionen
(i, j, n, m, x, y, w, h, r, g, b, a, c, d, s, f, p, q, t, l) —
in algorithmischem Code klarer als verbose
- opening_brace disabled — kollidiert mit SwiftFormats
wrapMultilineStatementBraces (SwiftFormat ist im Pre-Commit-Hook
und gewinnt)
Code-Modernisierungen (real, nicht nur Annotations)
- Cloze.swift: regex-Tuple bekommt `swiftlint:disable large_tuple`-
Region — Regex-Output-Type ist Builder-bedingt nicht reduzierbar
- Media.swift: `data(using: .utf8)` → `Data(s.utf8)` (non-failable),
`String(data:as:)` → `String(bytes:encoding:)`
- CardsTheme.swift: HSL-Wert-Typ statt anonymes 3-Tupel —
konkretere Call-Sites, kein `large_tuple`-Warning mehr
- MediaCache.swift: `CacheEntry`-Struct statt 3-Tupel im Prune-Pfad
- GradeQueue / MediaCache / StudySession / MarketplaceStore: OSLog-
Interpolations auf lokale Variablen ziehen — fixt Swift-6-Strict-
Concurrency-Fail bei Actor-isolated-Property-Zugriff aus
@Sendable-Autoclosure
- DeckMutations.swift, MarketplaceModeration.swift: verschachtelte
VersionInfo-Sub-Types auf Top-Level (`PullUpdateVersion`,
`OwnedMarketplaceVersion`) — fixt `nesting`-Warning
- Tests/UnitTests/*.swift: alle `""".data(using: .utf8)!` migriert auf
`Data("""…""".utf8)`; force-cast `as!` in MutationEncodingTests
durch guard-let + throw ersetzt
Pragmatische Disables (mit Doc-Comment-Begründung)
- DeckEditorView / MarketplacePublishView / DeckDetailView /
PublicDeckView / DeckListView / CardEditorView / CardsAPI:
`swiftlint:disable type_body_length` (+ teilweise file_length)
als Region-Disable mit `enable` nach dem Struct. Begründung im
Doc-Comment: Multi-State-Maschinen mit shared Toolbar + Sheets;
Aufspalten würde nur @Binding-Plumbing produzieren
Auto-Format-Aufräumung
- Redundante `Sendable`-Conformance entfernt (Swift 6 leitet das
bei Wert-Typen mit Sendable-Mitgliedern automatisch ab)
- EnvironmentValues nutzt jetzt @Entry-Macro statt manueller
EnvironmentKey-Boilerplate
- Brace-Reformatting + Import-Sortierung auf allen 75 Files
Ergebnis: 80 Warnings + 3 Errors → 0 / 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
73f9081fa1
commit
aece169360
37 changed files with 489 additions and 349 deletions
|
|
@ -12,7 +12,7 @@ struct MarketplaceDecodingTests {
|
|||
|
||||
@Test("PublicDeckEntry aus Browse-Response")
|
||||
func decodesPublicDeckEntry() throws {
|
||||
let json = """
|
||||
let json = Data("""
|
||||
{
|
||||
"slug": "geografie-welt-top30",
|
||||
"title": "Geografie Welt Top 30",
|
||||
|
|
@ -34,7 +34,7 @@ struct MarketplaceDecodingTests {
|
|||
"pseudonym": false
|
||||
}
|
||||
}
|
||||
""".data(using: .utf8)!
|
||||
""".utf8)
|
||||
|
||||
let entry = try decoder().decode(PublicDeckEntry.self, from: json)
|
||||
#expect(entry.slug == "geografie-welt-top30")
|
||||
|
|
@ -46,12 +46,12 @@ struct MarketplaceDecodingTests {
|
|||
|
||||
@Test("ExploreResponse mit featured + trending")
|
||||
func decodesExploreResponse() throws {
|
||||
let json = """
|
||||
let json = Data("""
|
||||
{
|
||||
"featured": [],
|
||||
"trending": []
|
||||
}
|
||||
""".data(using: .utf8)!
|
||||
""".utf8)
|
||||
let res = try decoder().decode(ExploreResponse.self, from: json)
|
||||
#expect(res.featured.isEmpty)
|
||||
#expect(res.trending.isEmpty)
|
||||
|
|
@ -59,7 +59,7 @@ struct MarketplaceDecodingTests {
|
|||
|
||||
@Test("PublicDeckDetail mit camelCase 'latest_version'")
|
||||
func decodesPublicDeckDetail() throws {
|
||||
let json = """
|
||||
let json = Data("""
|
||||
{
|
||||
"deck": {
|
||||
"id": "deck_1",
|
||||
|
|
@ -88,7 +88,7 @@ struct MarketplaceDecodingTests {
|
|||
},
|
||||
"owner": null
|
||||
}
|
||||
""".data(using: .utf8)!
|
||||
""".utf8)
|
||||
|
||||
let detail = try decoder().decode(PublicDeckDetail.self, from: json)
|
||||
#expect(detail.deck.slug == "english-a2")
|
||||
|
|
@ -99,14 +99,14 @@ struct MarketplaceDecodingTests {
|
|||
|
||||
@Test("SubscribeResponse mit private_deck_id")
|
||||
func decodesSubscribeResponse() throws {
|
||||
let json = """
|
||||
let json = Data("""
|
||||
{
|
||||
"subscribed": true,
|
||||
"deck_slug": "english-a2",
|
||||
"current_version_id": "v_1",
|
||||
"private_deck_id": "private_deck_xyz"
|
||||
}
|
||||
""".data(using: .utf8)!
|
||||
""".utf8)
|
||||
let res = try decoder().decode(SubscribeResponse.self, from: json)
|
||||
#expect(res.subscribed == true)
|
||||
#expect(res.privateDeckId == "private_deck_xyz")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue